fix(federation): remove plaintext auth token from error log in getSharedSecret#41578
Open
DeepDiver1975 wants to merge 2 commits into
Open
fix(federation): remove plaintext auth token from error log in getSharedSecret#41578DeepDiver1975 wants to merge 2 commits into
DeepDiver1975 wants to merge 2 commits into
Conversation
…redSecret When getSharedSecret received an invalid token it logged both the attacker-supplied token and the expected valid token in plaintext: 'got "X" but expected "Y"'. Since the endpoint is @publicpage, any unauthenticated caller could trigger this log entry at will for any trusted server URL, potentially exposing the valid federation token to anyone with log-read access. Remove the dbHandler->getToken() call that existed solely to populate the log message, and replace the message with a non-disclosing string. Signed-off-by: Thomas Müller <thomas.mueller@owncloud.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSharedSecret(@publicpage) logged both the submitted and expected tokens in plaintext on failure:got "X" but expected "Y"getToken()DB call that existed only to populate the log, replacing the message with a generic non-disclosing stringSecurity Impact
Medium — requires secondary log-read access to exploit; unauthenticated trigger
Note
This PR touches the same file as
security/fix-federation-token-oracle— merge that one first to avoid conflicts.Test plan
testGetSharedSecretDoesNotLogTokenValuesasserts neither attacker nor stored token appears in the logged string; fails without fixmake test TEST_PHP_SUITE=apps/federation🤖 Generated with Claude Code