fix(files_sharing): enforce minimum search length in getUsers() and getGroups()#41580
Open
DeepDiver1975 wants to merge 3 commits into
Open
fix(files_sharing): enforce minimum search length in getUsers() and getGroups()#41580DeepDiver1975 wants to merge 3 commits into
DeepDiver1975 wants to merge 3 commits into
Conversation
…etGroups() The admin-configurable user.search_min_length was only enforced in getRemote() via isSearchable() but not in getUsers() or getGroups(). A 1-character search bypassed the intended restriction and allowed authenticated users to enumerate users even when a higher minimum was configured. Add the missing isSearchable() guard to both methods. Signed-off-by: Thomas Müller <thomas.mueller@owncloud.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
… setUp Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getUsers()andgetGroups()inShareesControlleronly blocked empty strings, not strings shorter than the admin-configureduser.search_min_lengthisSearchable()was already enforced ingetRemote()but not in the other two search methodsisSearchable()guard, closing the bypassSecurity Impact
Low — authenticated-only endpoint; bypass only relevant when admin raises min length above default
Test plan
testGetUsersBlocksShortSearchTerm()andtestGetGroupsBlocksShortSearchTerm()assert that backends are never queried when search term is below configured minimummake test TEST_PHP_SUITE=apps/files_sharing🤖 Generated with Claude Code