fix(command): restrict allowed_classes in CommandJob unserialize() to prevent RCE#41582
Open
DeepDiver1975 wants to merge 2 commits into
Open
fix(command): restrict allowed_classes in CommandJob unserialize() to prevent RCE#41582DeepDiver1975 wants to merge 2 commits into
DeepDiver1975 wants to merge 2 commits into
Conversation
… prevent RCE CommandJob::run() called unserialize() without the allowed_classes option, enabling PHP Object Injection via POP gadget chains (Guzzle, Symfony, Doctrine) if an attacker can write to the oc_jobs table. Replace bare unserialize() with a two-pass strategy: Pass 1 uses allowed_classes=false to safely extract the stored class name without instantiating anything. After verifying the class implements ICommand, Pass 2 permits only that specific class, blocking all gadget chains. Signed-off-by: Thomas Müller <thomas.mueller@owncloud.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommandJob::run()called\unserialize($data)withoutallowed_classes, allowing PHP Object Injection if an attacker writes a crafted payload tooc_jobs.argument(e.g. via SQL injection or shared-hosting DB access)__wakeup()/__destruct()gadget chains from Guzzle, Symfony, and Doctrine could achieve RCE as the web-server userSecurity Impact
High (defense-in-depth) — exploitation requires prior DB write access; escalates that to full RCE
Test plan
ICommandobjects still execute correctlymake test TEST_PHP_SUITE=lib/Command🤖 Generated with Claude Code