fix(files_external): sanitize exception messages in storage status response#41585
Open
DeepDiver1975 wants to merge 2 commits into
Open
fix(files_external): sanitize exception messages in storage status response#41585DeepDiver1975 wants to merge 2 commits into
DeepDiver1975 wants to merge 2 commits into
Conversation
…sponse The catch-all Exception handler in updateStorageStatus() set the storage statusMessage to get_class($e).": ".$e->getMessage(), which for Guzzle/cURL exceptions includes the resolved IP, port, and cURL error code. This created an internal network oracle: authenticated users with external storage access could distinguish "connection refused" from "timed out" from "no DNS" to map internal topology. Log the full exception server-side and return a generic l10n string to the client instead. Signed-off-by: Thomas Müller <thomas.mueller@owncloud.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\Exceptioncatch block inupdateStorageStatus()returned raw exception messages (including GuzzlecURL error 7: Failed to connect to 10.0.0.x) in the JSONstatusMessagefieldl10nstring to clientSecurity Impact
Medium — internal network reconnaissance oracle for authenticated users with external storage access
Note
This PR touches
StoragesController.php— mergesecurity/fix-files-external-ssrffirst to avoid conflicts.Test plan
testUpdateStorageStatusDoesNotLeakExceptionDetailsInStatusMessageasserts IP addresses and exception class names do not appear instatusMessage; fails without fixmake test TEST_PHP_SUITE=apps/files_external🤖 Generated with Claude Code