fix(login): prevent user enumeration via differential password reset UI#41586
Open
DeepDiver1975 wants to merge 3 commits into
Open
fix(login): prevent user enumeration via differential password reset UI#41586DeepDiver1975 wants to merge 3 commits into
DeepDiver1975 wants to merge 3 commits into
Conversation
showLoginForm() called userManager->get($user) and checked canChangePassword() to decide whether to show "Wrong password. Reset it?" or just "Wrong password.". LDAP users (canChangePassword=false) produced a different UI than non-existent users (check skipped), giving attackers an oracle to identify users on non-password-change backends. Remove the backend capability check entirely. canResetPassword now stays true unless lost_password_link is explicitly set to "disabled", making the login-failure response identical for all users. Signed-off-by: Thomas Müller <thomas.mueller@owncloud.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
…arning Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showLoginForm()showed different UI for LDAP users (no "Reset it?" link) vs non-existent users, creating an unauthenticated oracle to enumerate LDAP userscanChangePassword()backend check;canResetPasswordis alwaystrueunlesslost_password_link=disabledSecurity Impact
Low — user enumeration limited to backends without password-change support (e.g. LDAP); requires login attempts
Note
This PR touches the same files as
security/fix-login-brute-force— merge that one first.Test plan
testShowLoginFormCanResetPasswordUniformForNonExistentUserand updated existing tests assertcanResetPassword=trueregardless of backend type; fail without fixmake test TEST_PHP_SUITE=core/Controller🤖 Generated with Claude Code