[stable6] Fixed missing files on SMB storage #7369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files with attribute "N" weren't parsed out of the file list returned by smbclient. It seems that these files appear when created on a Linux SMB mount directly and that have no executable bit.
Contributor
|
very good 👍 |
|
The inspection completed: No new issues |
|
🚀 Test Passed. 🚀 |
Contributor
|
👍 |
icewind1991
added a commit
that referenced
this pull request
Feb 24, 2014
[stable6] Fixed missing files on SMB storage
Contributor
Author
|
@karlitschek backport to stable5 ? Forward port not needed as @icewind1991 's new SMB storage is planned for OC7. |
Contributor
|
yes. please. makes sense |
Contributor
Author
|
Backported to stable5 as owncloud-archive/3rdparty@736fecf I also did a quick test and the files in question can be seen. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files with attribute "N" weren't parsed out of the file list returned by
smbclient. It seems that these files appear when created on a Linux SMB
mount directly and that have no executable bit.
@icewind1991 for some reason it seems we missed fixing this on stable6 / stable5.
Please review @karlitschek @icewind1991 @schiesbn