Skip to content

Conversation

@PVince81
Copy link
Contributor

Fixes #6585

While comparing the branches I found additional completely invalid texts (the second commit) so I've included them.

Please review @karlitschek @DeepDiver1975 @schiesbn @nickvergessen

@karlitschek
Copy link
Contributor

👍 but please use "Sie" instead of "Du"

@PVince81
Copy link
Contributor Author

@karlitschek I just double checked and the whole "de.php" file on stable6 is using "Du", so I think this change is correct.
The "Sie" is used in "de_DE.php"

@karlitschek
Copy link
Contributor

true. Sorry for the noise

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that be "%s hat »%s« mit dir geteilt" because the item is still shared?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but that's the translation text I found on master. Might be something to discuss on Transifex.

@Niduroki
Copy link
Member

👍

@ghost
Copy link

ghost commented Feb 26, 2014

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/3370/

@PVince81
Copy link
Contributor Author

I've raised #7436 to fix that unit test failure due to PHP trying to be clever.

@PVince81
Copy link
Contributor Author

@owncloud-bot retest this please

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@ghost
Copy link

ghost commented Feb 26, 2014

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/3379/

@DeepDiver1975
Copy link
Member

👍

DeepDiver1975 added a commit that referenced this pull request Feb 26, 2014
…nslation

[stable6] Backported incorrect translation texts for German
@DeepDiver1975 DeepDiver1975 merged commit d265d29 into stable6 Feb 26, 2014
@DeepDiver1975 DeepDiver1975 deleted the stable6-fixmailnotificationtranslation branch February 26, 2014 21:18
@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants