Skip to content

Conversation

@dupondje
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Jul 18, 2014

Thanks a lot for your contribution! Contributions to the core repo require a signed contributors agreement http://owncloud.org/contribute/agreement/ Alternatively you can add a comment here stating that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@dupondje
Copy link
Contributor Author

Feel free to use the code contribution. Its just a minor translation change ...

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@enoch85
Copy link
Member

enoch85 commented Jul 18, 2014

@PVince81 Ok to merge?

@PVince81
Copy link
Contributor

No, translations need to be fixed on Transifex, not here.
These will be overwritten next time the bot pulls the new translations from Transifex.

@PVince81
Copy link
Contributor

@wakeup can you take care of moving these to transifex ?
I believe that @dupondje does not have an account there.

@vgezer
Copy link
Contributor

vgezer commented Jul 18, 2014

@PVince81 I think we can merge this as we do not pull translations for stable7 branch anymore.

Regarding to master branch: On Transifex, I am only a local coordinator and cannot edit other languages. @DeepDiver1975 can you give me permission on transifex? Thanks

@DeepDiver1975
Copy link
Member

@PVince81 this change is okay - this is a change against stable7 branch with in no longer updated from transifex.

👍

@PVince81
Copy link
Contributor

Okay 👍

Can someone make the change directly on transifex to make sure the translation will be on master as well ?

PVince81 pushed a commit that referenced this pull request Jul 21, 2014
Small translation fix. Fixes: #9719
@PVince81 PVince81 merged commit f80f8d9 into owncloud:stable7 Jul 21, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Aug 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants