Switch back to upstream openapi-generator#33
Merged
Conversation
dschmidt
force-pushed
the
upstream_generator
branch
from
282a8ee to
6374716
Compare
micbar
reviewed
Mar 2, 2022
| # FIXME: switch back to openapitools/openapi-generator-cli | ||
| # when https://github.com/OpenAPITools/openapi-generator/pull/11490 is merged | ||
| 'openapi-generator-image': 'owncloudci/openapi-generator' | ||
| 'openapi-generator-image': 'openapitools/openapi-generator-cli:latest' |
Contributor
There was a problem hiding this comment.
could you pin that to the current commID?
Member
Author
There was a problem hiding this comment.
No. I don't think they publish docker images for every commit:
https://hub.docker.com/r/openapitools/openapi-generator-cli/tags
Member
Author
There was a problem hiding this comment.
Which doesn't have the commit we need ... see PR description
micbar
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately we still need to use latest, as the fix from our fork is merged upstream but not released yet.
TODO in follow up PR: Pin version.
FIXES: #30