Skip to content

[full-ci] web bump. fix flaky e2e test.#7748

Merged
micbar merged 4 commits intomasterfrom
updateWeb
Nov 20, 2023
Merged

[full-ci] web bump. fix flaky e2e test.#7748
micbar merged 4 commits intomasterfrom
updateWeb

Conversation

@ScharfViktor
Copy link
Copy Markdown
Contributor

@ScharfViktor ScharfViktor commented Nov 17, 2023 •
edited
Loading

@update-docs
Copy link
Copy Markdown

update-docs Bot commented Nov 17, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor
Copy link
Copy Markdown
Contributor Author

ScharfViktor commented Nov 17, 2023 •
edited
Loading

It seams that v8.0.0-alpha.8 doesn't have this one owncloud/web#9931 so e2e internal link test fails
@JammingBen that means I need new web release?

@JammingBen
Copy link
Copy Markdown
Contributor

JammingBen commented Nov 17, 2023

@JammingBen that means I need new web release?

Yes exactly. I can create one now if you want?

@ScharfViktor
Copy link
Copy Markdown
Contributor Author

ScharfViktor commented Nov 17, 2023

Yes exactly. I can create one now if you want?

That would be great and would help make our CI happy

@JammingBen JammingBen requested a review from kulmann as a code owner November 17, 2023 14:15
@JammingBen
Copy link
Copy Markdown
Contributor

JammingBen commented Nov 17, 2023

@ScharfViktor I bumped Web and the commit id, let's see. If it still fails, something is probably still flaky...

@ScharfViktor
Copy link
Copy Markdown
Contributor Author

ScharfViktor commented Nov 17, 2023

@JammingBen thank you 👍

@ScharfViktor
Copy link
Copy Markdown
Contributor Author

ScharfViktor commented Nov 17, 2023

let's see. If it still fails, something is probably still flaky...

all of e2e passed on the first try except of this: quick fix: owncloud/web#9986

@micbar micbar enabled auto-merge November 17, 2023 20:15
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

phil-davis
phil-davis approved these changes Nov 20, 2023
View reviewed changes
Comment thread tests/config/drone/banned-password-list.txt
12345678
123
ownCloud
ownCloud-1 No newline at end of file
Copy link
Copy Markdown
Contributor

@phil-davis phil-davis Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this needs to be added because it was added to the web tests by PR owncloud/web#9948
And so when running the web tests in cis, a similar banned-password-list is needed.

@micbar micbar merged commit c541c52 into master Nov 20, 2023
@delete-merged-branch delete-merged-branch Bot deleted the updateWeb branch November 20, 2023 07:25
ownclouders pushed a commit that referenced this pull request Nov 20, 2023
@micbar
Merge pull request #7748 from owncloud/updateWeb
56d8d05 
[full-ci] web bump. fix flaky e2e test.
@ScharfViktor ScharfViktor mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek

@micbar micbar Awaiting requested review from micbar

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@kulmann kulmann Awaiting requested review from kulmann

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[QA] Flaky public-link e2e test Flaky e2e tests. opening public link

4 participants

@ScharfViktor @JammingBen @phil-davis @micbar