Skip to content

[full-ci] change e2e test for enforce pass#9948

Merged
ScharfViktor merged 2 commits intomasterfrom
setPassforLink
Nov 17, 2023
Merged

[full-ci] change e2e test for enforce pass#9948
ScharfViktor merged 2 commits intomasterfrom
setPassforLink

Conversation

@ScharfViktor
Copy link
Copy Markdown
Contributor

@ScharfViktor ScharfViktor commented Nov 16, 2023 •
edited
Loading

ToDo: get rid of:

@update-docs
Copy link
Copy Markdown

update-docs Bot commented Nov 16, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor changed the title change e2e test for enforce pass [full-ci] change e2e test for enforce pass Nov 16, 2023
@ScharfViktor ScharfViktor force-pushed the setPassforLink branch 2 times, most recently from f8829b3 to 13cb420 Compare November 16, 2023 13:42
@ScharfViktor ScharfViktor mentioned this pull request Nov 16, 2023
Closed
@ScharfViktor ScharfViktor marked this pull request as ready for review November 17, 2023 09:29
@grgprarup grgprarup mentioned this pull request Nov 17, 2023
Closed
saw-jan
saw-jan reviewed Nov 17, 2023
View reviewed changes
Comment thread .drone.star Outdated
saw-jan
saw-jan reviewed Nov 17, 2023
View reviewed changes
Comment thread tests/e2e/support/objects/app-files/utils/editor.ts Outdated
saw-jan
saw-jan reviewed Nov 17, 2023
View reviewed changes
Comment thread tests/e2e/support/objects/app-files/utils/editor.ts
saw-jan
saw-jan approved these changes Nov 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor ScharfViktor merged commit 4f2ac8b into master Nov 17, 2023
@delete-merged-branch delete-merged-branch Bot deleted the setPassforLink branch November 17, 2023 12:14
ownclouders pushed a commit that referenced this pull request Nov 17, 2023
@ScharfViktor
[full-ci] change e2e test for enforce pass (#9948)
1836160 
* change e2e test for enforce pass

* fix after review
@phil-davis phil-davis mentioned this pull request Nov 20, 2023
Merged
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@ScharfViktor @AlexAndBear
[full-ci] change e2e test for enforce pass (#9948)
90e1b02 
* change e2e test for enforce pass

* fix after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

+1 more reviewer

@JammingBen JammingBen JammingBen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ScharfViktor @JammingBen @saw-jan