Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

New collaborators flow#2450

Merged
PVince81 merged 1 commit into
masterfrom
collaborators-ux-leap
Nov 25, 2019
Merged

New collaborators flow#2450
PVince81 merged 1 commit into
masterfrom
collaborators-ux-leap

Conversation

@PVince81

@PVince81 PVince81 commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Description

Related Issue

Fixes #1908

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@PVince81 PVince81 added this to the Milestone 1: Phoenix for users milestone Nov 12, 2019
@PVince81 PVince81 self-assigned this Nov 12, 2019
@PVince81 PVince81 mentioned this pull request Nov 12, 2019
Closed
@PVince81

PVince81 commented Nov 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Todos:

  • autofocus on autocomplete on arrival
  • adjust styles and wording
  • use oc-collaborator in NewCollaborator
  • merge NewCollaborator and EditCollaborator
  • normalize sharing models on SDK level
  • kill toggleCollaboratorsEdit ? => keep for "unsaved changes confirmation"
  • kill oc-text ? (it was needed for accordion)
  • don't hide save button in case of no changes ? or make it disabled
  • use uk-card for sidebar sections? or an own design system element ?
  • solve clickable uk-icon issue with hand cursor / highlight ?

@ownclouders

ownclouders commented Nov 12, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests RestrictSharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6370/

20191112-145311-805.png
20191112-145312-066.png
20191112-145358-925.png
20191112-145359-280.png
20191112-145446-890.png
20191112-145447-183.png
20191112-145534-561.png
20191112-145534-861.png
20191112-145642-731.png
20191112-145643-103.png
20191112-145750-854.png
20191112-145751-173.png
20191112-145857-730.png
20191112-145857-976.png
20191112-150005-103.png
20191112-150005-398.png
20191112-150112-397.png
20191112-150112-698.png
20191112-150113-031.png
20191112-150219-844.png
20191112-150220-128.png
20191112-150220-418.png
20191112-150327-171.png
20191112-150327-546.png
20191112-150434-636.png
20191112-150434-905.png

@ownclouders

ownclouders commented Nov 12, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6370/

20191112-145046-079.png
20191112-145046-340.png
20191112-145046-554.png
20191112-145152-850.png
20191112-145153-196.png
20191112-145153-552.png
20191112-145254-384.png
20191112-145254-687.png
20191112-145254-997.png
20191112-145352-027.png
20191112-145352-274.png
20191112-145352-629.png
20191112-145448-563.png
20191112-145448-780.png
20191112-145448-973.png
20191112-145545-083.png
20191112-145545-300.png
20191112-145545-543.png

@ownclouders

ownclouders commented Nov 12, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6370/

20191112-150916-986.png
20191112-151012-403.png
20191112-151201-422.png
20191112-151316-553.png
20191112-151453-857.png
20191112-151550-400.png
20191112-151705-775.png
20191112-151803-138.png
20191112-151926-257.png
20191112-152048-748.png

@ownclouders

ownclouders commented Nov 12, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingPermissionsUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6370/

20191112-145155-483.png
20191112-145155-733.png
20191112-145302-078.png
20191112-145302-444.png
20191112-145406-827.png
20191112-145407-180.png
20191112-145512-252.png
20191112-145512-505.png
20191112-145616-831.png
20191112-145617-099.png
20191112-145721-125.png
20191112-145721-598.png
20191112-145826-586.png
20191112-145826-937.png
20191112-145931-280.png
20191112-145931-617.png
20191112-150036-753.png
20191112-150037-022.png
20191112-150037-269.png
20191112-150142-369.png
20191112-150142-636.png
20191112-150142-950.png
20191112-150247-466.png
20191112-150247-746.png
20191112-150247-963.png
20191112-150353-449.png
20191112-150353-701.png
20191112-150353-963.png
20191112-150459-060.png
20191112-150459-484.png
20191112-150459-879.png
20191112-150603-524.png
20191112-150603-771.png
20191112-150604-015.png
20191112-150709-960.png
20191112-150710-384.png
20191112-150710-868.png
20191112-150816-392.png
20191112-150816-688.png
20191112-150816-984.png
20191112-150926-494.png
20191112-150926-932.png
20191112-150927-367.png
20191112-151030-734.png
20191112-151031-080.png
20191112-151031-420.png
20191112-151134-089.png
20191112-151134-369.png
20191112-151239-505.png
20191112-151239-745.png
20191112-151344-885.png
20191112-151345-129.png
20191112-151451-869.png
20191112-151452-165.png
20191112-151556-198.png
20191112-151556-456.png
20191112-151701-816.png
20191112-151702-119.png
20191112-151806-866.png
20191112-151807-156.png
20191112-151807-462.png
20191112-151912-618.png
20191112-151913-043.png
20191112-151913-464.png
20191112-152020-501.png
20191112-152020-749.png
20191112-152021-079.png
20191112-152125-257.png
20191112-152125-536.png
20191112-152125-792.png
20191112-152230-930.png
20191112-152231-194.png
20191112-152231-588.png
20191112-152336-344.png
20191112-152336-599.png
20191112-152336-907.png
20191112-152709-106.png
20191112-152709-557.png
20191112-152827-136.png
20191112-152827-545.png
20191112-152952-388.png
20191112-152952-750.png
20191112-152953-198.png
20191112-153115-501.png
20191112-153115-773.png
20191112-153116-174.png
20191112-153239-279.png
20191112-153239-516.png
20191112-153239-837.png
20191112-153358-551.png
20191112-153358-817.png
20191112-153359-096.png
20191112-153515-765.png
20191112-153516-099.png
20191112-153516-387.png
20191112-153633-720.png
20191112-153634-026.png
20191112-153634-379.png

@ownclouders

ownclouders commented Nov 12, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6370/

20191112-145045-110.png
20191112-145045-438.png
20191112-145205-332.png
20191112-145205-761.png
20191112-145316-778.png
20191112-145317-183.png
20191112-145426-751.png
20191112-145427-183.png
20191112-145539-057.png
20191112-145539-385.png
20191112-145648-870.png
20191112-145649-071.png
20191112-145750-643.png
20191112-145750-879.png
20191112-145751-204.png
20191112-145853-661.png
20191112-145853-941.png
20191112-145854-179.png
20191112-145956-817.png
20191112-145957-283.png
20191112-145957-717.png
20191112-150059-751.png
20191112-150059-952.png
20191112-150100-327.png
20191112-150200-582.png
20191112-150200-894.png
20191112-150201-265.png
20191112-150301-446.png
20191112-150301-758.png
20191112-150302-145.png
20191112-150405-065.png
20191112-150405-286.png
20191112-150503-000.png
20191112-150503-237.png
20191112-150557-806.png
20191112-150558-030.png
20191112-150653-010.png
20191112-150653-250.png
20191112-150748-017.png
20191112-150748-284.png
20191112-150849-957.png
20191112-150850-198.png
20191112-150949-533.png
20191112-150949-863.png
20191112-151046-254.png
20191112-151046-471.png
20191112-151307-061.png
20191112-151307-318.png
20191112-151307-682.png
20191112-151406-278.png
20191112-151406-506.png
20191112-151406-800.png
20191112-151504-723.png
20191112-151505-119.png
20191112-151505-524.png
20191112-151610-096.png
20191112-151610-361.png
20191112-151610-711.png
20191112-151907-527.png
20191112-151907-748.png
20191112-151952-818.png
20191112-151953-034.png
20191112-152040-529.png
20191112-152040-946.png
20191112-152124-562.png
20191112-152124-911.png
20191112-152209-286.png
20191112-152209-623.png
20191112-152252-955.png
20191112-152253-314.png
20191112-152330-346.png
20191112-152330-606.png
20191112-152408-526.png
20191112-152408-770.png

@ownclouders

ownclouders commented Nov 12, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests Resharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6370/

20191112-145425-127.png
20191112-145425-445.png
20191112-145459-379.png
20191112-145459-646.png
20191112-145553-507.png
20191112-145553-743.png
20191112-145554-089.png
20191112-145647-800.png
20191112-145648-036.png
20191112-145648-329.png
20191112-145742-785.png
20191112-145742-987.png
20191112-145743-353.png
20191112-145842-241.png
20191112-145842-450.png
20191112-145842-716.png
20191112-145942-426.png
20191112-145942-773.png
20191112-145943-153.png
20191112-150040-778.png
20191112-150041-091.png
20191112-150041-453.png
20191112-150136-299.png
20191112-150136-571.png
20191112-150136-828.png
20191112-150233-420.png
20191112-150233-658.png
20191112-150233-888.png
20191112-150333-288.png
20191112-150333-612.png
20191112-150333-988.png
20191112-150433-066.png
20191112-150433-365.png
20191112-150433-715.png
20191112-150530-864.png
20191112-150531-135.png
20191112-150531-437.png
20191112-150627-023.png
20191112-150627-351.png
20191112-150627-649.png
20191112-150723-220.png
20191112-150723-500.png
20191112-150723-919.png
20191112-150818-692.png
20191112-150818-907.png
20191112-150819-295.png
20191112-150913-572.png
20191112-150913-901.png
20191112-150914-236.png
20191112-151009-389.png
20191112-151009-609.png
20191112-151009-809.png
20191112-151105-242.png
20191112-151105-484.png
20191112-151105-730.png
20191112-151203-204.png
20191112-151203-404.png
20191112-151203-768.png
20191112-151303-159.png
20191112-151303-504.png
20191112-151303-940.png
20191112-151402-975.png
20191112-151403-224.png
20191112-151403-603.png
20191112-151502-858.png
20191112-151503-226.png
20191112-151503-644.png
20191112-151602-480.png
20191112-151602-683.png
20191112-151602-885.png
20191112-151701-542.png
20191112-151701-738.png
20191112-151702-091.png
20191112-151757-049.png
20191112-151757-376.png
20191112-151757-675.png
20191112-151834-954.png
20191112-151835-378.png
20191112-151915-444.png
20191112-151915-765.png
20191112-151954-151.png
20191112-151954-351.png
20191112-152034-067.png
20191112-152034-340.png
20191112-152112-972.png
20191112-152113-194.png
20191112-152152-874.png
20191112-152153-087.png
20191112-152230-868.png
20191112-152231-078.png
20191112-152304-984.png
20191112-152305-235.png
20191112-152338-814.png
20191112-152339-029.png
20191112-152412-964.png
20191112-152413-165.png
20191112-152447-189.png
20191112-152447-401.png
20191112-152520-881.png
20191112-152521-096.png
20191112-152614-622.png
20191112-152614-859.png
20191112-152615-095.png
20191112-152708-645.png
20191112-152708-868.png
20191112-152709-075.png
20191112-152802-435.png
20191112-152802-634.png
20191112-152802-851.png
20191112-152856-416.png
20191112-152856-623.png
20191112-152856-880.png
20191112-152950-457.png
20191112-152950-692.png
20191112-152950-895.png
20191112-153044-108.png
20191112-153044-324.png
20191112-153044-644.png

@ownclouders

ownclouders commented Nov 12, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6370/

20191112-151006-532.png
20191112-151006-643.png
20191112-151051-672.png
20191112-151051-762.png
20191112-151136-739.png
20191112-151136-862.png
20191112-151222-895.png
20191112-151223-027.png
20191112-151331-138.png
20191112-151331-247.png
20191112-151435-730.png
20191112-151435-840.png
20191112-151540-925.png
20191112-151541-050.png
20191112-151645-828.png
20191112-151645-939.png
20191112-151751-666.png
20191112-151751-753.png
20191112-151859-310.png
20191112-151859-457.png
20191112-152004-565.png
20191112-152004-658.png
20191112-152004-767.png
20191112-152108-859.png
20191112-152108-958.png
20191112-152109-085.png
20191112-152212-682.png
20191112-152212-764.png
20191112-152212-870.png
20191112-152316-578.png
20191112-152316-684.png
20191112-152316-811.png
20191112-152422-647.png
20191112-152422-743.png
20191112-152422-866.png
20191112-152527-185.png
20191112-152527-286.png
20191112-152527-380.png
20191112-152654-726.png
20191112-152654-840.png
20191112-152804-609.png
20191112-152804-713.png
20191112-152933-340.png
20191112-152933-458.png
20191112-153059-868.png
20191112-153059-938.png
20191112-153203-522.png
20191112-153203-645.png
20191112-153203-733.png
20191112-153306-249.png
20191112-153306-432.png
20191112-153306-435.png
20191112-153409-482.png
20191112-153409-580.png
20191112-153409-673.png
20191112-153512-115.png
20191112-153512-230.png
20191112-153512-372.png
20191112-153614-320.png
20191112-153614-415.png
20191112-153614-515.png
20191112-153717-116.png
20191112-153717-213.png
20191112-153717-343.png

@ownclouders

ownclouders commented Nov 12, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6370/

20191112-151231-191.png
20191112-151231-605.png
20191112-151328-822.png
20191112-151329-022.png
20191112-151428-435.png
20191112-151428-777.png
20191112-151525-114.png
20191112-151525-470.png
20191112-151643-017.png
20191112-151643-335.png
20191112-151759-678.png
20191112-151759-904.png
20191112-151917-206.png
20191112-151917-484.png
20191112-152035-122.png
20191112-152035-299.png
20191112-152151-942.png
20191112-152152-149.png
20191112-152309-258.png
20191112-152309-559.png
20191112-152425-582.png
20191112-152425-821.png
20191112-152426-122.png
20191112-152540-077.png
20191112-152540-411.png
20191112-152540-819.png
20191112-152656-899.png
20191112-152657-052.png
20191112-152657-211.png
20191112-152814-054.png
20191112-152814-214.png
20191112-152814-382.png
20191112-152930-189.png
20191112-152930-511.png
20191112-152930-919.png
20191112-153045-890.png
20191112-153046-078.png
20191112-153046-266.png
20191112-153205-599.png
20191112-153205-893.png
20191112-153329-425.png
20191112-153329-715.png
20191112-153448-743.png
20191112-153448-922.png
20191112-153609-099.png
20191112-153609-270.png
20191112-153723-548.png
20191112-153723-846.png
20191112-153724-094.png
20191112-153835-905.png
20191112-153836-154.png
20191112-153836-425.png
20191112-153951-869.png
20191112-153952-062.png
20191112-153952-239.png
20191112-154105-172.png
20191112-154105-445.png
20191112-154105-650.png
20191112-154220-218.png
20191112-154220-474.png
20191112-154220-759.png
20191112-154332-049.png
20191112-154332-395.png
20191112-154332-631.png

@ownclouders

ownclouders commented Nov 12, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingPermissionsGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6370/

20191112-145052-708.png
20191112-145053-010.png
20191112-145155-607.png
20191112-145155-813.png
20191112-145258-071.png
20191112-145258-401.png
20191112-145359-625.png
20191112-145359-901.png
20191112-145501-711.png
20191112-145502-019.png
20191112-145603-511.png
20191112-145603-781.png
20191112-145704-958.png
20191112-145705-241.png
20191112-145806-662.png
20191112-145806-873.png
20191112-145908-238.png
20191112-145908-442.png
20191112-150009-585.png
20191112-150009-798.png
20191112-150110-882.png
20191112-150111-102.png
20191112-150212-979.png
20191112-150213-195.png
20191112-150315-396.png
20191112-150315-590.png
20191112-150417-944.png
20191112-150418-225.png
20191112-150519-782.png
20191112-150519-988.png
20191112-150621-739.png
20191112-150621-938.png
20191112-150721-161.png
20191112-150721-555.png
20191112-150819-001.png
20191112-150819-267.png
20191112-150919-558.png
20191112-150919-752.png
20191112-151016-122.png
20191112-151016-332.png
20191112-151112-435.png
20191112-151112-630.png
20191112-151208-328.png
20191112-151208-539.png
20191112-151304-577.png
20191112-151304-771.png
20191112-151407-074.png
20191112-151407-273.png
20191112-151503-256.png
20191112-151503-466.png
20191112-151559-145.png
20191112-151559-353.png
20191112-151655-179.png
20191112-151655-528.png
20191112-151750-720.png
20191112-151750-922.png
20191112-151850-165.png
20191112-151850-381.png
20191112-151946-588.png
20191112-151946-801.png
20191112-152042-050.png
20191112-152042-273.png
20191112-152138-115.png
20191112-152138-405.png
20191112-152233-666.png
20191112-152233-878.png
20191112-152329-209.png
20191112-152329-437.png
20191112-152426-287.png
20191112-152426-513.png
20191112-152521-973.png
20191112-152522-177.png
20191112-152617-473.png
20191112-152617-687.png
20191112-152718-249.png
20191112-152718-443.png
20191112-152820-319.png
20191112-152820-871.png
20191112-152922-024.png
20191112-152922-229.png
20191112-153020-655.png
20191112-153020-957.png
20191112-153116-592.png
20191112-153116-796.png
20191112-153211-852.png
20191112-153212-058.png
20191112-153307-085.png
20191112-153307-354.png
20191112-153402-589.png
20191112-153402-798.png
20191112-153458-035.png
20191112-153458-262.png
20191112-153553-864.png
20191112-153554-142.png
20191112-153649-388.png
20191112-153649-758.png
20191112-153744-871.png
20191112-153745-082.png
20191112-153840-499.png
20191112-153840-829.png
20191112-153935-737.png
20191112-153935-989.png
20191112-154031-042.png
20191112-154031-326.png
20191112-154129-557.png
20191112-154129-943.png
20191112-154227-965.png
20191112-154228-170.png
20191112-154323-274.png
20191112-154323-449.png
20191112-154418-886.png
20191112-154419-171.png

@PVince81

PVince81 commented Nov 13, 2019

Copy link
Copy Markdown
Contributor Author

Slide replacing whole sidebar

phoenix-full-sidebar-slide

Slide replacing sidebar under the file info

phoenix-sidebar-tab-slide

I personally prefer the latter to keep context. (it's also the one pushed to this branch)

@PVince81

PVince81 commented Nov 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author
  • BUG: weird bug when switching repeatedly between "Links" and "Collaborators" tags:

image

@ownclouders

ownclouders commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests RestrictSharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6417/

20191113-130721-499.png
20191113-130721-776.png
20191113-130737-953.png
20191113-130738-255.png
20191113-130754-358.png
20191113-130754-582.png
20191113-130810-669.png
20191113-130811-038.png
20191113-130846-988.png
20191113-130847-196.png
20191113-130923-131.png
20191113-130923-358.png
20191113-130959-130.png
20191113-130959-320.png
20191113-131055-429.png
20191113-131055-706.png
20191113-131131-498.png
20191113-131131-707.png
20191113-131131-991.png
20191113-131207-797.png
20191113-131207-993.png
20191113-131208-199.png
20191113-131243-880.png
20191113-131244-069.png
20191113-131339-476.png
20191113-131339-678.png

@ownclouders

ownclouders commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6417/

20191113-131056-535.png
20191113-131056-914.png
20191113-131057-294.png
20191113-131141-447.png
20191113-131141-691.png
20191113-131141-999.png
20191113-131225-838.png
20191113-131226-082.png
20191113-131226-474.png
20191113-131310-227.png
20191113-131310-572.png
20191113-131310-840.png
20191113-131414-950.png
20191113-131415-221.png
20191113-131415-562.png
20191113-131458-934.png
20191113-131459-243.png
20191113-131459-580.png
20191113-131547-873.png
20191113-131548-115.png
20191113-131548-435.png
20191113-131635-211.png
20191113-131635-528.png
20191113-131635-891.png
20191113-132037-597.png
20191113-132037-860.png
20191113-132038-205.png
20191113-132123-787.png
20191113-132124-066.png
20191113-132124-329.png
20191113-132208-060.png
20191113-132208-307.png
20191113-132208-683.png
20191113-132252-515.png
20191113-132252-787.png
20191113-132253-138.png
20191113-132336-975.png
20191113-132337-236.png
20191113-132337-520.png
20191113-132420-825.png
20191113-132421-071.png
20191113-132421-306.png
20191113-132504-063.png
20191113-132504-437.png
20191113-132504-851.png
20191113-132549-050.png
20191113-132549-318.png
20191113-132549-569.png

@ownclouders

ownclouders commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6417/

20191113-131615-073.png
20191113-131615-219.png
20191113-131632-282.png
20191113-131632-428.png
20191113-131650-019.png
20191113-131650-229.png
20191113-131707-183.png
20191113-131707-309.png
20191113-131745-092.png
20191113-131745-227.png
20191113-131822-773.png
20191113-131822-898.png
20191113-131900-109.png
20191113-131900-290.png
20191113-131938-003.png
20191113-131938-212.png
20191113-132015-938.png
20191113-132016-116.png
20191113-132053-402.png
20191113-132053-598.png
20191113-132130-092.png
20191113-132130-255.png
20191113-132130-444.png
20191113-132206-803.png
20191113-132206-956.png
20191113-132207-088.png
20191113-132243-514.png
20191113-132243-670.png
20191113-132243-880.png
20191113-132339-864.png
20191113-132339-977.png
20191113-132340-186.png
20191113-132416-271.png
20191113-132416-453.png
20191113-132416-633.png
20191113-132452-354.png
20191113-132452-471.png
20191113-132452-594.png
20191113-132532-485.png
20191113-132532-634.png
20191113-132532-790.png
20191113-132612-097.png
20191113-132612-264.png
20191113-132612-418.png
20191113-132652-576.png
20191113-132652-711.png
20191113-132752-344.png
20191113-132752-527.png
20191113-132835-107.png
20191113-132835-368.png
20191113-132916-098.png
20191113-132916-213.png
20191113-132951-359.png
20191113-132951-482.png
20191113-132951-639.png
20191113-133035-499.png
20191113-133035-734.png
20191113-133035-927.png
20191113-133118-683.png
20191113-133118-828.png
20191113-133118-957.png
20191113-133201-812.png
20191113-133201-950.png
20191113-133202-121.png
20191113-133244-010.png
20191113-133244-124.png
20191113-133244-384.png
20191113-133325-781.png
20191113-133325-921.png
20191113-133326-152.png

@ownclouders

ownclouders commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6417/

20191113-132200-152.png
20191113-132235-960.png
20191113-132327-416.png
20191113-132422-430.png
20191113-132535-349.png
20191113-132613-814.png
20191113-132710-218.png
20191113-132806-607.png
20191113-132849-991.png
20191113-132952-830.png

@ownclouders

ownclouders commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6417/

20191113-131049-419.png
20191113-131049-931.png
20191113-131159-738.png
20191113-131200-089.png
20191113-131329-785.png
20191113-131330-149.png
20191113-131418-937.png
20191113-131419-192.png
20191113-131513-501.png
20191113-131513-743.png
20191113-131600-888.png
20191113-131601-139.png
20191113-131645-686.png
20191113-131645-932.png
20191113-131646-235.png
20191113-131726-933.png
20191113-131727-186.png
20191113-131727-455.png
20191113-131829-231.png
20191113-131829-491.png
20191113-131829-813.png
20191113-131911-131.png
20191113-131911-394.png
20191113-131911-630.png
20191113-131954-356.png
20191113-131954-586.png
20191113-131954-826.png
20191113-132035-624.png
20191113-132035-874.png
20191113-132036-226.png
20191113-132120-720.png
20191113-132121-049.png
20191113-132201-182.png
20191113-132201-428.png
20191113-132302-038.png
20191113-132302-291.png
20191113-132341-737.png
20191113-132341-977.png
20191113-132425-427.png
20191113-132425-661.png
20191113-132525-468.png
20191113-132525-753.png
20191113-132605-766.png
20191113-132606-040.png
20191113-132647-602.png
20191113-132647-895.png
20191113-132824-837.png
20191113-132825-097.png
20191113-132825-344.png
20191113-132913-439.png
20191113-132913-787.png
20191113-132914-105.png
20191113-132957-081.png
20191113-132957-346.png
20191113-132957-581.png
20191113-133046-937.png
20191113-133047-181.png
20191113-133047-433.png
20191113-133333-829.png
20191113-133334-128.png
20191113-133409-374.png
20191113-133409-766.png
20191113-133505-617.png
20191113-133505-934.png
20191113-133538-586.png
20191113-133538-908.png
20191113-133615-301.png
20191113-133615-570.png
20191113-133711-816.png
20191113-133712-192.png
20191113-133740-933.png
20191113-133741-279.png
20191113-133828-633.png
20191113-133829-159.png

@ownclouders

ownclouders commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6417/

20191113-131915-240.png
20191113-131915-379.png
20191113-131959-191.png
20191113-131959-329.png
20191113-132022-445.png
20191113-132022-614.png
20191113-132045-485.png
20191113-132045-602.png
20191113-132128-840.png
20191113-132128-928.png
20191113-132211-822.png
20191113-132212-078.png
20191113-132256-415.png
20191113-132256-560.png
20191113-132340-093.png
20191113-132340-191.png
20191113-132425-262.png
20191113-132425-326.png
20191113-132512-826.png
20191113-132512-914.png
20191113-132558-904.png
20191113-132558-998.png
20191113-132559-101.png
20191113-132641-337.png
20191113-132641-438.png
20191113-132641-526.png
20191113-132724-231.png
20191113-132724-321.png
20191113-132724-508.png
20191113-132807-307.png
20191113-132807-409.png
20191113-132807-505.png
20191113-132852-246.png
20191113-132852-431.png
20191113-132852-601.png
20191113-132935-732.png
20191113-132935-855.png
20191113-132935-957.png
20191113-133022-784.png
20191113-133022-912.png
20191113-133023-010.png
20191113-133109-918.png
20191113-133110-033.png
20191113-133110-223.png
20191113-133158-039.png
20191113-133158-146.png
20191113-133246-003.png
20191113-133246-083.png
20191113-133416-732.png
20191113-133416-830.png
20191113-133505-441.png
20191113-133505-572.png
20191113-133547-335.png
20191113-133547-416.png
20191113-133547-512.png
20191113-133629-260.png
20191113-133629-408.png
20191113-133629-490.png
20191113-133710-658.png
20191113-133710-754.png
20191113-133710-847.png
20191113-133752-650.png
20191113-133752-767.png
20191113-133752-877.png
20191113-133835-105.png
20191113-133835-207.png
20191113-133835-326.png
20191113-133916-591.png
20191113-133916-676.png
20191113-133916-823.png

@ownclouders

ownclouders commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingPermissionsUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6417/

20191113-132540-503.png
20191113-132540-762.png
20191113-132626-046.png
20191113-132626-353.png
20191113-132708-766.png
20191113-132709-006.png
20191113-132811-610.png
20191113-132811-887.png
20191113-132855-098.png
20191113-132855-372.png
20191113-132937-614.png
20191113-132937-892.png
20191113-133027-863.png
20191113-133028-415.png
20191113-133119-161.png
20191113-133119-674.png
20191113-133209-875.png
20191113-133210-229.png
20191113-133210-740.png
20191113-133301-234.png
20191113-133301-485.png
20191113-133301-870.png
20191113-133352-456.png
20191113-133353-176.png
20191113-133353-622.png
20191113-133502-730.png
20191113-133503-029.png
20191113-133503-327.png
20191113-133611-371.png
20191113-133611-645.png
20191113-133612-029.png
20191113-133706-067.png
20191113-133706-448.png
20191113-133706-837.png
20191113-133754-704.png
20191113-133755-099.png
20191113-133755-493.png
20191113-133841-521.png
20191113-133841-877.png
20191113-133842-123.png
20191113-133930-216.png
20191113-133930-619.png
20191113-133930-996.png
20191113-134041-300.png
20191113-134041-901.png
20191113-134042-493.png
20191113-134154-380.png
20191113-134154-644.png
20191113-134245-125.png
20191113-134245-382.png
20191113-134336-065.png
20191113-134336-587.png
20191113-134424-183.png
20191113-134424-577.png
20191113-134514-572.png
20191113-134514-855.png
20191113-134606-091.png
20191113-134606-522.png
20191113-134656-657.png
20191113-134657-061.png
20191113-134657-587.png
20191113-134746-821.png
20191113-134747-239.png
20191113-134747-815.png
20191113-134835-103.png
20191113-134835-474.png
20191113-134835-838.png
20191113-134924-398.png
20191113-134924-741.png
20191113-134925-188.png
20191113-135034-819.png
20191113-135035-229.png
20191113-135035-498.png
20191113-135125-494.png
20191113-135125-741.png
20191113-135126-136.png
20191113-135424-581.png
20191113-135425-044.png
20191113-135523-343.png
20191113-135523-724.png
20191113-135624-460.png
20191113-135624-741.png
20191113-135625-056.png
20191113-135728-152.png
20191113-135728-537.png
20191113-135728-895.png
20191113-135829-727.png
20191113-135830-158.png
20191113-135830-659.png
20191113-135933-250.png
20191113-135933-507.png
20191113-135933-877.png
20191113-140034-472.png
20191113-140034-868.png
20191113-140035-122.png
20191113-140134-336.png
20191113-140134-745.png
20191113-140135-251.png

@ownclouders

ownclouders commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests Resharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6417/

20191113-133839-138.png
20191113-133839-635.png
20191113-133934-396.png
20191113-133934-879.png
20191113-134027-697.png
20191113-134028-089.png
20191113-134028-630.png
20191113-134119-675.png
20191113-134119-936.png
20191113-134120-441.png
20191113-134236-734.png
20191113-134236-985.png
20191113-134237-299.png
20191113-134327-200.png
20191113-134327-486.png
20191113-134327-964.png
20191113-134438-028.png
20191113-134438-465.png
20191113-134438-913.png
20191113-134528-632.png
20191113-134528-936.png
20191113-134529-200.png
20191113-134618-778.png
20191113-134619-146.png
20191113-134619-614.png
20191113-134708-565.png
20191113-134708-965.png
20191113-134709-529.png
20191113-134820-471.png
20191113-134820-843.png
20191113-134821-599.png
20191113-134910-757.png
20191113-134911-343.png
20191113-134911-795.png
20191113-135000-709.png
20191113-135001-163.png
20191113-135001-452.png
20191113-135051-745.png
20191113-135052-158.png
20191113-135052-597.png
20191113-135143-506.png
20191113-135143-868.png
20191113-135144-120.png
20191113-135234-093.png
20191113-135234-414.png
20191113-135234-849.png
20191113-135325-105.png
20191113-135325-467.png
20191113-135325-833.png
20191113-135415-480.png
20191113-135415-977.png
20191113-135416-435.png
20191113-135506-884.png
20191113-135507-347.png
20191113-135507-697.png
20191113-135557-122.png
20191113-135557-463.png
20191113-135557-860.png
20191113-135647-694.png
20191113-135648-045.png
20191113-135648-517.png
20191113-135758-737.png
20191113-135759-110.png
20191113-135759-516.png
20191113-135911-628.png
20191113-135912-039.png
20191113-135912-389.png
20191113-140005-616.png
20191113-140005-976.png
20191113-140006-224.png
20191113-140056-215.png
20191113-140056-637.png
20191113-140057-041.png
20191113-140208-342.png
20191113-140208-555.png
20191113-140208-951.png
20191113-140240-733.png
20191113-140241-194.png
20191113-140313-547.png
20191113-140313-899.png
20191113-140403-924.png
20191113-140404-219.png
20191113-140454-973.png
20191113-140455-379.png
20191113-140527-226.png
20191113-140527-572.png
20191113-140619-695.png
20191113-140619-950.png
20191113-140650-825.png
20191113-140651-258.png
20191113-140742-112.png
20191113-140742-892.png
20191113-140834-030.png
20191113-140834-557.png
20191113-140905-327.png
20191113-140905-625.png
20191113-140956-664.png
20191113-140956-928.png
20191113-141030-258.png
20191113-141030-715.png
20191113-141121-126.png
20191113-141121-719.png
20191113-141122-333.png
20191113-141212-908.png
20191113-141213-331.png
20191113-141213-715.png
20191113-141304-480.png
20191113-141304-756.png
20191113-141305-271.png
20191113-141355-856.png
20191113-141356-082.png
20191113-141356-510.png
20191113-141448-649.png
20191113-141449-128.png
20191113-141449-557.png
20191113-141539-484.png
20191113-141539-849.png
20191113-141540-311.png

@ownclouders

ownclouders commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingPermissionsGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6417/

20191113-131832-442.png
20191113-131832-684.png
20191113-131947-774.png
20191113-131948-114.png
20191113-132041-380.png
20191113-132041-764.png
20191113-132135-749.png
20191113-132136-046.png
20191113-132229-664.png
20191113-132229-995.png
20191113-132324-137.png
20191113-132324-526.png
20191113-132419-850.png
20191113-132420-179.png
20191113-132512-079.png
20191113-132512-367.png
20191113-132604-009.png
20191113-132604-250.png
20191113-132656-338.png
20191113-132656-604.png
20191113-132750-133.png
20191113-132750-429.png
20191113-132843-027.png
20191113-132843-374.png
20191113-132937-082.png
20191113-132937-338.png
20191113-133100-344.png
20191113-133100-615.png
20191113-133209-968.png
20191113-133210-702.png
20191113-133314-128.png
20191113-133314-390.png
20191113-133410-046.png
20191113-133410-355.png
20191113-133505-650.png
20191113-133506-205.png
20191113-133558-582.png
20191113-133558-829.png
20191113-133650-821.png
20191113-133651-103.png
20191113-133743-333.png
20191113-133743-955.png
20191113-133836-785.png
20191113-133837-048.png
20191113-133951-701.png
20191113-133952-113.png
20191113-134107-860.png
20191113-134108-360.png
20191113-134202-007.png
20191113-134202-446.png
20191113-134257-826.png
20191113-134258-391.png
20191113-134357-299.png
20191113-134357-660.png
20191113-134451-859.png
20191113-134452-474.png
20191113-134546-286.png
20191113-134546-636.png
20191113-134642-117.png
20191113-134642-449.png
20191113-134736-936.png
20191113-134737-576.png
20191113-134830-767.png
20191113-134831-322.png
20191113-134926-343.png
20191113-134926-607.png
20191113-135021-631.png
20191113-135021-951.png
20191113-135115-177.png
20191113-135115-567.png
20191113-135209-207.png
20191113-135209-487.png
20191113-135303-580.png
20191113-135304-020.png
20191113-135356-947.png
20191113-135357-181.png
20191113-135511-169.png
20191113-135511-878.png
20191113-135606-090.png
20191113-135606-385.png
20191113-135701-005.png
20191113-135701-477.png
20191113-135753-757.png
20191113-135754-215.png
20191113-135908-033.png
20191113-135908-692.png
20191113-140021-938.png
20191113-140022-209.png
20191113-140114-509.png
20191113-140114-850.png
20191113-140214-346.png
20191113-140214-629.png
20191113-140311-056.png
20191113-140311-371.png
20191113-140425-434.png
20191113-140425-763.png
20191113-140530-917.png
20191113-140531-151.png
20191113-140616-448.png
20191113-140616-757.png
20191113-140701-550.png
20191113-140701-827.png
20191113-140746-938.png
20191113-140747-276.png
20191113-140839-657.png
20191113-140839-929.png
20191113-140939-487.png
20191113-140939-757.png
20191113-141037-269.png
20191113-141037-540.png
20191113-141123-584.png
20191113-141124-037.png

@ownclouders

ownclouders commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests RestrictSharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6420/

20191113-145244-162.png
20191113-145244-345.png
20191113-145300-787.png
20191113-145301-166.png
20191113-145315-926.png
20191113-145316-190.png
20191113-145333-906.png
20191113-145334-202.png
20191113-145417-531.png
20191113-145417-784.png
20191113-145459-630.png
20191113-145459-822.png
20191113-145543-872.png
20191113-145544-075.png
20191113-145621-930.png
20191113-145622-160.png
20191113-145658-833.png
20191113-145659-056.png
20191113-145659-321.png
20191113-145733-950.png
20191113-145734-150.png
20191113-145734-374.png
20191113-145808-603.png
20191113-145808-821.png
20191113-145843-404.png
20191113-145843-788.png

@ownclouders

ownclouders commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6420/

20191113-145538-104.png
20191113-145538-436.png
20191113-145538-938.png
20191113-145624-690.png
20191113-145625-080.png
20191113-145625-453.png
20191113-145710-988.png
20191113-145711-324.png
20191113-145711-620.png
20191113-145756-497.png
20191113-145756-776.png
20191113-145756-969.png
20191113-145842-725.png
20191113-145842-988.png
20191113-145843-374.png
20191113-145924-918.png
20191113-145925-345.png
20191113-145925-705.png
20191113-150035-329.png
20191113-150035-547.png
20191113-150035-814.png
20191113-150145-993.png
20191113-150146-323.png
20191113-150146-728.png
20191113-150610-984.png
20191113-150611-189.png
20191113-150611-458.png
20191113-150651-846.png
20191113-150652-144.png
20191113-150652-561.png
20191113-150729-699.png
20191113-150730-048.png
20191113-150730-412.png
20191113-150807-366.png
20191113-150807-692.png
20191113-150808-008.png
20191113-150846-690.png
20191113-150846-893.png
20191113-150847-158.png
20191113-150925-252.png
20191113-150925-533.png
20191113-150925-843.png
20191113-151003-291.png
20191113-151003-521.png
20191113-151003-745.png
20191113-151040-746.png
20191113-151040-990.png
20191113-151041-317.png

@ownclouders

ownclouders commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6420/

20191113-145430-224.png
20191113-145430-450.png
20191113-145512-889.png
20191113-145513-444.png
20191113-145617-038.png
20191113-145617-381.png
20191113-145657-211.png
20191113-145657-403.png
20191113-145738-996.png
20191113-145739-208.png
20191113-145838-231.png
20191113-145838-552.png
20191113-145919-117.png
20191113-145919-315.png
20191113-145919-631.png
20191113-145953-888.png
20191113-145954-088.png
20191113-145954-305.png
20191113-150027-324.png
20191113-150027-537.png
20191113-150027-746.png
20191113-150101-214.png
20191113-150101-426.png
20191113-150101-624.png
20191113-150135-880.png
20191113-150136-182.png
20191113-150136-494.png
20191113-150231-173.png
20191113-150231-378.png
20191113-150231-595.png
20191113-150304-330.png
20191113-150304-595.png
20191113-150342-397.png
20191113-150342-587.png
20191113-150416-300.png
20191113-150416-535.png
20191113-150449-018.png
20191113-150449-216.png
20191113-150522-091.png
20191113-150522-301.png
20191113-150615-077.png
20191113-150615-288.png
20191113-150650-823.png
20191113-150651-057.png
20191113-150724-617.png
20191113-150724-849.png
20191113-150846-114.png
20191113-150846-287.png
20191113-150846-488.png
20191113-150922-499.png
20191113-150922-727.png
20191113-150923-033.png
20191113-150958-885.png
20191113-150959-078.png
20191113-150959-298.png
20191113-151034-703.png
20191113-151034-904.png
20191113-151035-141.png
20191113-151206-706.png
20191113-151206-931.png
20191113-151232-539.png
20191113-151232-806.png
20191113-151323-181.png
20191113-151323-378.png
20191113-151345-408.png
20191113-151345-598.png
20191113-151408-164.png
20191113-151408-380.png
20191113-151429-606.png
20191113-151429-831.png
20191113-151447-013.png
20191113-151447-238.png
20191113-151507-361.png
20191113-151507-567.png

@ownclouders

ownclouders commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingPermissionsUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6420/

20191113-145340-296.png
20191113-145340-643.png
20191113-145415-718.png
20191113-145415-968.png
20191113-145449-008.png
20191113-145449-227.png
20191113-145522-521.png
20191113-145522-732.png
20191113-145556-217.png
20191113-145556-459.png
20191113-145629-493.png
20191113-145629-741.png
20191113-145702-564.png
20191113-145702-767.png
20191113-145735-820.png
20191113-145736-057.png
20191113-145830-041.png
20191113-145830-393.png
20191113-145830-649.png
20191113-145907-392.png
20191113-145907-653.png
20191113-145907-965.png
20191113-150005-371.png
20191113-150005-576.png
20191113-150005-889.png
20191113-150040-773.png
20191113-150041-001.png
20191113-150041-208.png
20191113-150118-733.png
20191113-150119-048.png
20191113-150119-255.png
20191113-150156-575.png
20191113-150156-809.png
20191113-150157-156.png
20191113-150234-531.png
20191113-150234-796.png
20191113-150234-984.png
20191113-150333-312.png
20191113-150333-669.png
20191113-150334-009.png
20191113-150411-020.png
20191113-150411-317.png
20191113-150411-634.png
20191113-150449-376.png
20191113-150449-652.png
20191113-150449-947.png
20191113-150549-182.png
20191113-150549-418.png
20191113-150627-578.png
20191113-150627-827.png
20191113-150704-760.png
20191113-150704-990.png
20191113-150743-066.png
20191113-150743-383.png
20191113-150840-707.png
20191113-150840-953.png
20191113-150919-278.png
20191113-150919-599.png
20191113-150957-121.png
20191113-150957-317.png
20191113-150957-673.png
20191113-151035-068.png
20191113-151035-329.png
20191113-151035-672.png
20191113-151114-674.png
20191113-151115-011.png
20191113-151115-419.png
20191113-151154-184.png
20191113-151154-684.png
20191113-151155-019.png
20191113-151232-135.png
20191113-151232-342.png
20191113-151232-572.png
20191113-151309-370.png
20191113-151309-637.png
20191113-151310-106.png
20191113-151509-707.png
20191113-151509-945.png
20191113-151553-776.png
20191113-151553-985.png
20191113-151637-759.png
20191113-151638-118.png
20191113-151638-441.png
20191113-151741-523.png
20191113-151742-071.png
20191113-151742-494.png
20191113-151826-458.png
20191113-151826-678.png
20191113-151826-941.png
20191113-151930-724.png
20191113-151930-975.png
20191113-151931-394.png
20191113-152035-882.png
20191113-152036-081.png
20191113-152036-442.png
20191113-152117-164.png
20191113-152117-503.png
20191113-152117-753.png

@ownclouders

ownclouders commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests Resharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6420/

20191113-145557-417.png
20191113-145557-659.png
20191113-145614-237.png
20191113-145614-524.png
20191113-145651-485.png
20191113-145651-835.png
20191113-145652-402.png
20191113-145737-413.png
20191113-145737-658.png
20191113-145738-066.png
20191113-145842-506.png
20191113-145842-893.png
20191113-145843-324.png
20191113-145927-685.png
20191113-145928-154.png
20191113-145928-533.png
20191113-150012-151.png
20191113-150012-404.png
20191113-150012-606.png
20191113-150052-312.png
20191113-150052-649.png
20191113-150052-896.png
20191113-150136-994.png
20191113-150137-480.png
20191113-150137-855.png
20191113-150242-814.png
20191113-150243-202.png
20191113-150243-612.png
20191113-150347-278.png
20191113-150347-496.png
20191113-150347-785.png
20191113-150432-025.png
20191113-150432-414.png
20191113-150433-030.png
20191113-150537-700.png
20191113-150538-110.png
20191113-150538-432.png
20191113-150622-295.png
20191113-150622-655.png
20191113-150622-936.png
20191113-150726-096.png
20191113-150726-339.png
20191113-150726-738.png
20191113-150810-602.png
20191113-150810-995.png
20191113-150811-489.png
20191113-150854-272.png
20191113-150854-638.png
20191113-150855-050.png
20191113-150939-631.png
20191113-150939-887.png
20191113-150940-286.png
20191113-151024-831.png
20191113-151025-323.png
20191113-151025-816.png
20191113-151109-481.png
20191113-151109-718.png
20191113-151110-066.png
20191113-151215-446.png
20191113-151215-702.png
20191113-151216-028.png
20191113-151259-987.png
20191113-151300-349.png
20191113-151300-588.png
20191113-151346-194.png
20191113-151346-497.png
20191113-151346-979.png
20191113-151430-901.png
20191113-151431-289.png
20191113-151431-518.png
20191113-151514-919.png
20191113-151515-218.png
20191113-151515-607.png
20191113-151559-088.png
20191113-151559-509.png
20191113-151559-874.png
20191113-151643-437.png
20191113-151643-772.png
20191113-151728-313.png
20191113-151728-590.png
20191113-151753-789.png
20191113-151754-227.png
20191113-151839-690.png
20191113-151840-135.png
20191113-151925-878.png
20191113-151926-190.png
20191113-151951-427.png
20191113-151951-808.png
20191113-152017-955.png
20191113-152018-233.png
20191113-152043-127.png
20191113-152043-467.png
20191113-152129-564.png
20191113-152130-024.png
20191113-152156-745.png
20191113-152156-983.png
20191113-152242-642.png
20191113-152243-083.png
20191113-152308-986.png
20191113-152309-457.png
20191113-152355-182.png
20191113-152355-611.png
20191113-152356-096.png
20191113-152440-812.png
20191113-152441-250.png
20191113-152441-809.png
20191113-152526-228.png
20191113-152526-607.png
20191113-152526-976.png
20191113-152611-215.png
20191113-152611-465.png
20191113-152611-806.png
20191113-152717-282.png
20191113-152717-637.png
20191113-152717-874.png
20191113-152825-513.png
20191113-152825-821.png
20191113-152826-274.png

individual-it
individual-it reviewed Nov 22, 2019
View reviewed changes
Comment thread tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js Outdated
individual-it
individual-it reviewed Nov 22, 2019
View reviewed changes
Comment thread tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js
individual-it
individual-it reviewed Nov 22, 2019
View reviewed changes
Comment thread tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js Outdated
@individual-it

individual-it commented Nov 22, 2019

Copy link
Copy Markdown
Member

the change collaborator button does not change the mouse when h-over

@PVince81

PVince81 commented Nov 22, 2019

Copy link
Copy Markdown
Contributor Author

the change collaborator button does not change the mouse when h-over

known general issue with icons: owncloud/owncloud-design-system#488

@PVince81
PVince81 force-pushed the collaborators-ux-leap branch from 4e28b79 to c4980eb Compare November 22, 2019 11:40
@PVince81

PVince81 commented Nov 22, 2019

Copy link
Copy Markdown
Contributor Author

Rebased and adjusted tests based on comments, except for the one about the autocomplete "no results" case

@ownclouders

ownclouders commented Nov 22, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests RestrictSharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6699/

20191122-114932-586.png
20191122-115014-142.png
20191122-115303-510.png
20191122-115343-525.png
20191122-115424-033.png
20191122-115444-272.png

@ownclouders

ownclouders commented Nov 22, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingFilePermissionsGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6699/

20191122-114841-916.png
20191122-114842-297.png
20191122-114927-426.png
20191122-114927-775.png
20191122-115011-234.png
20191122-115011-554.png
20191122-115054-343.png
20191122-115054-691.png
20191122-115158-581.png
20191122-115158-895.png
20191122-115243-248.png
20191122-115243-584.png
20191122-115326-071.png
20191122-115326-339.png
20191122-115409-765.png
20191122-115410-168.png
20191122-115454-557.png
20191122-115454-750.png
20191122-115537-486.png
20191122-115537-688.png
20191122-115641-687.png
20191122-115641-904.png
20191122-115726-653.png
20191122-115726-874.png
20191122-115811-158.png
20191122-115811-357.png
20191122-115916-571.png
20191122-115916-901.png
20191122-120000-601.png
20191122-120000-964.png
20191122-120044-554.png
20191122-120044-910.png

@ownclouders

ownclouders commented Nov 22, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6699/

20191122-114915-206.png
20191122-114956-850.png
20191122-115101-360.png
20191122-115143-110.png
20191122-115225-829.png
20191122-115328-182.png
20191122-115645-317.png
20191122-115728-429.png
20191122-115812-928.png
20191122-115856-644.png
20191122-120315-166.png

@ownclouders

ownclouders commented Nov 22, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingPermissionsUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6699/

20191122-115015-403.png
20191122-115114-631.png
20191122-115155-697.png
20191122-115236-250.png
20191122-115318-194.png
20191122-115419-135.png
20191122-115519-972.png
20191122-115600-731.png
20191122-115641-200.png
20191122-115744-426.png
20191122-115947-767.png
20191122-120027-966.png
20191122-120107-477.png
20191122-120147-191.png
20191122-120227-076.png
20191122-120307-808.png
20191122-120440-614.png
20191122-120549-297.png
20191122-120636-838.png
20191122-120724-875.png
20191122-120810-161.png
20191122-120858-919.png

@ownclouders

ownclouders commented Nov 22, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6699/

20191122-115204-927.png
20191122-115255-923.png
20191122-115343-041.png
20191122-115439-967.png
20191122-115526-817.png
20191122-115613-548.png
20191122-115705-926.png
20191122-115816-195.png
20191122-115907-953.png
20191122-115958-617.png
20191122-120049-140.png
20191122-120141-373.png
20191122-120416-415.png
20191122-120507-120.png
20191122-120553-305.png
20191122-120641-219.png
20191122-120748-643.png
20191122-120835-549.png
20191122-120922-652.png
20191122-121010-573.png

@ownclouders

ownclouders commented Nov 22, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6699/

20191122-120212-477.png
20191122-120304-207.png
20191122-120534-002.png
20191122-120554-160.png
20191122-120753-228.png
20191122-120835-926.png
20191122-120918-892.png
20191122-121002-411.png
20191122-121040-536.png
20191122-121122-524.png

@ownclouders

ownclouders commented Nov 22, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6699/

20191122-120231-633.png
20191122-120325-129.png
20191122-120608-602.png
20191122-120628-711.png
20191122-120832-300.png
20191122-120908-578.png
20191122-120950-290.png
20191122-121035-845.png
20191122-121123-800.png
20191122-121208-692.png

@ownclouders

ownclouders commented Nov 22, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests Resharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6699/

20191122-115123-048.png
20191122-115210-057.png
20191122-115318-199.png
20191122-115405-667.png
20191122-115513-933.png
20191122-115603-599.png
20191122-115650-997.png
20191122-115739-366.png
20191122-115848-185.png
20191122-115936-956.png
20191122-120046-062.png
20191122-120156-780.png
20191122-120308-114.png
20191122-120410-310.png
20191122-120520-375.png
20191122-120612-355.png
20191122-120722-871.png
20191122-120810-775.png
20191122-120921-862.png
20191122-121032-921.png
20191122-121141-878.png
20191122-121230-573.png
20191122-121320-585.png
20191122-121413-994.png
20191122-121814-431.png
20191122-121903-421.png
20191122-121953-948.png
20191122-122043-410.png
20191122-122133-798.png
20191122-122221-841.png
20191122-122314-042.png
20191122-122403-663.png
20191122-122513-781.png
20191122-122603-279.png
20191122-122714-068.png
20191122-122824-807.png

@ownclouders

ownclouders commented Nov 22, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingFolderPermissionsGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6699/

20191122-115027-682.png
20191122-115137-632.png
20191122-115243-275.png
20191122-115350-709.png
20191122-115457-574.png
20191122-115605-380.png
20191122-115732-147.png
20191122-115842-229.png
20191122-115951-690.png
20191122-120102-220.png
20191122-120228-659.png
20191122-120336-080.png
20191122-120443-478.png
20191122-120611-766.png
20191122-120738-959.png
20191122-120846-487.png
20191122-121014-053.png
20191122-121122-910.png
20191122-121234-649.png
20191122-121404-178.png
20191122-121511-308.png
20191122-121638-719.png
20191122-121739-055.png
20191122-121840-052.png
20191122-121940-363.png
20191122-122040-379.png
20191122-122140-472.png
20191122-122240-734.png
20191122-122341-931.png
20191122-122442-047.png
20191122-122542-237.png
20191122-122642-828.png
20191122-122742-706.png
20191122-122902-279.png
20191122-123001-639.png
20191122-123101-145.png
20191122-123200-669.png
20191122-123300-378.png
20191122-123359-769.png
20191122-123459-014.png

@PVince81
PVince81 force-pushed the collaborators-ux-leap branch from c4980eb to 507040c Compare November 22, 2019 12:56
@PVince81

PVince81 commented Nov 22, 2019

Copy link
Copy Markdown
Contributor Author

I messed up the names. Fixed now. Expecting all tests to pass.
I also removed the "# workaround" line to avoid confusion. We can leave the test as is now and also in the future when "no results" dropdown is fixed as it won't affect it.

Then need approval for the tests from @individual-it and a code review from @LukasHirt

@ownclouders

ownclouders commented Nov 22, 2019

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingFilePermissionsGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/6701/

20191122-131538-272.png
20191122-131538-662.png
20191122-131702-373.png
20191122-131702-974.png
20191122-131803-393.png
20191122-131803-764.png
20191122-131924-615.png
20191122-131924-854.png
20191122-132047-532.png
20191122-132047-786.png
20191122-132209-189.png
20191122-132209-504.png
20191122-132312-258.png
20191122-132312-915.png
20191122-132414-399.png
20191122-132414-848.png
20191122-132521-649.png
20191122-132522-048.png
20191122-132624-111.png
20191122-132624-567.png
20191122-132725-756.png
20191122-132726-209.png
20191122-132828-461.png
20191122-132828-699.png
20191122-132930-677.png
20191122-132931-076.png
20191122-133034-858.png
20191122-133035-118.png
20191122-133137-231.png
20191122-133137-715.png
20191122-133258-903.png
20191122-133259-382.png

@individual-it

individual-it commented Nov 25, 2019

Copy link
Copy Markdown
Member

tests look good. some are failing I guess because there is a new suite since #2531 and And the user opens the share creation dialog in the webUI missing ?

@PVince81

PVince81 commented Nov 25, 2019

Copy link
Copy Markdown
Contributor Author

Yeah, basically every day I fix tests and rebase, new tests appear on master so I need to fix again 😢

Vincent Petry
New collaborators flow
1431ad6 
Editing and deleting colalborators is now happening inside a separate dialog instead of a series of accordions.

Fixed updating share in the state.

Adjusted acceptance tests for properly opening the dialog before
asserting or operating on roles or permissions.
@PVince81
PVince81 force-pushed the collaborators-ux-leap branch from 507040c to 1431ad6 Compare November 25, 2019 08:47
@PVince81

PVince81 commented Nov 25, 2019

Copy link
Copy Markdown
Contributor Author

Nope, this time I had it in my local workspace and somehow failed to commit it... Pushed now.

Thanks for the review.

@LukasHirt code review ?

@PVince81

PVince81 commented Nov 25, 2019

Copy link
Copy Markdown
Contributor Author

npm fail for "Notifications" test 😞

LukasHirt
LukasHirt approved these changes Nov 25, 2019
View reviewed changes

@LukasHirt LukasHirt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@PVince81

PVince81 commented Nov 25, 2019

Copy link
Copy Markdown
Contributor Author

since the notifications test is unrelated and passed the last time, I'll override and merge anyway

@PVince81
PVince81 merged commit d0eef89 into master Nov 25, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the collaborators-ux-leap branch November 25, 2019 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975
2 more reviewers
@individual-it individual-it individual-it left review comments
@LukasHirt LukasHirt LukasHirt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@PVince81 PVince81

Labels

Status:In-Progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Confusing layout in collaborators UI

4 participants

@PVince81 @ownclouders @individual-it @LukasHirt