fix(security): prevent command injection via additional-app input#42
Merged
Merged
Conversation
Pass inputs.additional-app through an environment variable instead of interpolating directly into run: shell commands, preventing shell metacharacter injection.
2 tasks
phil-davis
approved these changes
Apr 17, 2026
jvillafanez
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inputs.additional-appwas interpolated directly intorun:shell commands (cd apps/${{ inputs.additional-app }},php occ a:e ${{ inputs.additional-app }}) inphp-codestyle.ymlandphp-unit.ymlenv: ADDITIONAL_APPin the affected step and quote the variable in shellSecurity impact
CRITICAL — any caller can inject arbitrary shell commands via the
additional-appinput value.Test plan
🤖 Generated with Claude Code