fix(security): remove user-controlled values from step names#47
Closed
DeepDiver1975 wants to merge 1 commit into
Closed
fix(security): remove user-controlled values from step names#47DeepDiver1975 wants to merge 1 commit into
DeepDiver1975 wants to merge 1 commit into
Conversation
Step names containing ${{ inputs.app-name }} and
${{ inputs.additional-app }} allow callers to inject Unicode,
newlines, or misleading text into the GitHub Actions UI log,
enabling social engineering via manipulated CI output.
Replace with static names.
Member
Author
|
handled in #42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
name:fields injs-unit.yml,php-codestyle.yml, andphp-unit.ymlinterpolated${{ inputs.app-name }}and${{ inputs.additional-app }}directlyCheckout app,Checkout additional app,Setup app,Setup additional app)Security impact
MEDIUM — does not directly execute code, but enables UI spoofing and log manipulation that could be used for social engineering attacks against developers reviewing CI output.
Test plan
🤖 Generated with Claude Code