fix: UploadReady FileRef uses SpaceID instead of NodeID#560
Merged
2403905 merged 1 commit intoowncloud:mainfrom Mar 13, 2026
Merged
fix: UploadReady FileRef uses SpaceID instead of NodeID#5602403905 merged 1 commit intoowncloud:mainfrom
2403905 merged 1 commit intoowncloud:mainfrom
Conversation
The UploadReady event and upload-finished callback both set FileRef.ResourceId.OpaqueId to session.SpaceID() instead of session.NodeID(). This means every upload event reports the space root UUID as the file identifier. Additionally, the FileRef included an unnecessary Path field that is redundant now that the ResourceID field carries the correct node reference. This fixes both issues: - FileRef.OpaqueId: SpaceID() → NodeID() - FileRef.Path: removed (consumers should use ResourceID) owncloud/ocis#12056 owncloud#546 owncloud#547 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2403905
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.SpaceID()instead ofsession.NodeID()in both the postprocessing event and the upload-finished callback. Every upload event reported the space root UUID as the file identifier instead of the actual file node ID.ResourceIDfield with the correct node reference. Removed it from both locations.Related:
Test plan
go build ./pkg/storage/utils/decomposedfs/...passesgo test ./pkg/storage/utils/decomposedfs/...all tests pass🤖 Generated with Claude Code