MM: fix(advanced-search): detect OCR status + align UI with ODS#338
Merged
MM: fix(advanced-search): detect OCR status + align UI with ODS#338
Conversation
mmattel
force-pushed
the
mm_fix-advanced-search-translations
branch
from
8498aea to
9179f2f
Compare
paul43210
approved these changes
Mar 4, 2026
Contributor
paul43210
left a comment
paul43210
left a comment
There was a problem hiding this comment.
This is effectively the same as #334 (same base commits). Only difference is #334 has an additional fix: samsung → Samsung capitalization in KNOWN_CAMERA_MAKES (per mmattel's own feedback on #334).
Suggest merging #334 instead since it includes that fix, or cherry-picking the Samsung fix into this branch.
LGTM otherwise.
mmattel
force-pushed
the
mm_fix-advanced-search-translations
branch
4 times, most recently
from
beaa687 to
fc25915
Compare
mmattel
force-pushed
the
mm_fix-advanced-search-translations
branch
from
fc25915 to
9feb2ff
Compare
LukasHirt
reviewed
Mar 9, 2026
Collaborator
LukasHirt
left a comment
LukasHirt
left a comment
There was a problem hiding this comment.
Mostly questions than change requests. For future PRs, I would ask you to please limit the size because these large PRs are hard to review.
8 tasks
mmattel
force-pushed
the
mm_fix-advanced-search-translations
branch
from
9feb2ff to
b52f996
Compare
oCIS does not expose an explicit OCR flag in config.json or capabilities. When Tika with Tesseract is running, content search is enabled but OCR always showed as Disabled. Fall back to checking capabilities.search.property.content.enabled as a proxy for OCR support. Fixes #331 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace all custom button styling with ODS button classes, swap emoji icons for SVG icons, convert native selects to FilterSelect chip dropdowns with custom text support, replace hardcoded colors with CSS variables for dark mode support, and remove dead CSS rules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Google Pixel phones store 'Google' as the EXIF camera make. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix double-quote content search causing 500 error (strip user-entered
quotes before KQL wrapping to avoid "..."" invalid syntax)
- Fix date year input scrambling (only auto-swap when both dates are
fully formed YYYY-MM-DD, not during mid-edit typing)
- Change date display to ISO 8601 format (yyyy-mm-dd) per international
standard
- Add real image thumbnails in search results (authenticated DAV preview
fetch with blob URL caching, shown in list and grid views)
- Fix Open in Files 404 (use /f/{fileId} short URL instead of broken
/preview/ pattern)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ad of ShallowRef ShallowRef<Map> props caused 'Cannot read properties of undefined (reading get)' because Vue doesn't handle ShallowRef as prop types correctly. Replace with a simple thumbnailVersion number prop that increments when new thumbnails load, triggering v-memo re-evaluation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… columns - Add real image thumbnails in table view Name column - Use table-layout: fixed with column widths so Path truncates instead of causing horizontal scroll - Click any column header to sort (click again to reverse). Active sort shows triangle indicator. Date columns default to descending. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…uts, size shorthand - Fix lint: add aria-label to FilterSelect custom input - Fix e2e tests: update selectors to match actual UI classes - Camera make/model: add wildcards so "Nikon" matches "NIKON CORPORATION" - Date inputs: add @change handler so manual typing updates KQL - File size: support K/M/G shorthand (e.g., "1M" = 1048576 bytes) - Rebased onto upstream/main (includes merged #337) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Browser warning: form field element should have an id or name attribute. Generates a unique id from the label prop (e.g., filter-custom-camera-make). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Unit test expectations now match the new wildcard behavior: photo.cameramake:Canon → photo.cameramake:*Canon* Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Prevent NaN from appearing in KQL when non-numeric input is entered in size/ISO/aperture/focal length fields. NaN range parts are now silently dropped so only valid numeric expressions appear in the query. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ix, error clear - Replace inline SVGs with OcIcon component (check, close, arrow-down-s, arrow-right-s) in FilterChip, FilterSelect, SearchFilters - Replace raw HTML buttons with OcButton in FilterSelect dropdown - Replace <span class="oc-tag"> with OcTag in FilterChip - Fix date range scramble: remove @input handlers from date fields, keep only @change (fires on blur, not per-keystroke) - Fix sticky error: clearFilters() now resets state.error to null - Replace setTimeout with nextTick in FilterSelect click-outside handler - Add @ownclouders/design-system dependency and externalize for build Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…rt broken externals - Use globally registered oc-icon/oc-tag/oc-button (no imports needed) - Revert design-system externalization that broke runtime loading - Remove date auto-swap logic that scrambled start date during typing - Use @change instead of @input for date fields - Add max="9999-12-31" to constrain year to 4 digits - Use plain <button> with OC CSS classes in dropdowns (oc-button component's click events break click-outside handlers) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…IS styling Replace custom chip/dropdown implementation with oc-filter-chip component (Tippy.js positioning, click-outside handling, chip button styling). Use oc-button, oc-checkbox, oc-icon from design system for list items. Add colorful file type icons via --oc-color-icon-* CSS variables. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The media type filter now uses oc-filter-chip which renders with class "oc-filter-chip-button" instead of our old "filter-chip-btn". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mmattel
force-pushed
the
mm_fix-advanced-search-translations
branch
from
b52f996 to
e9f1646
Compare
LukasHirt
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References: #334 (fix(advanced-search): detect OCR status + align UI with ODS)
Fixes: #331 (Small issues for advanced-search)
This PR is the CI working version of the referenced PR above.
@paul43210 FYI