Conversation
kulmann
suggested changes
Oct 31, 2024
kulmann
reviewed
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
mmattel
commented
Oct 31, 2024
kulmann
reviewed
Oct 31, 2024
mmattel
commented
Oct 31, 2024
Contributor
Author
|
@kulmann we now only have added |
Contributor
Author
|
Are CI things related to this PR, it does not change code? Was green before... Rebasing |
mmattel
force-pushed
the
add_resource_name
branch
from
c265b44 to
024c523
Compare
|
Contributor
Seems to be unrelated |
kulmann
approved these changes
Oct 31, 2024
Contributor
kulmann
left a comment
kulmann
left a comment
There was a problem hiding this comment.
Thank you for aligning this 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #11839 (Harmonize naming translations resources)
Add a
resorce_nameproperty to each TX definition (packages/xxx/.tx/config)activities-->web-activities(<repo-name>-<resource-name>Now, we can destinguish by the name in TX where the source is located:
web-yyyweb-extension-yyy...