-
Notifications
You must be signed in to change notification settings - Fork 191
[tests-only][full-ci] use predefined users with web e2e tests #12473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3808b77 to
a5c0e81
Compare
nirajacharya2
commented
Apr 24, 2025
b16feee to
ff894e1
Compare
deyankiteworks
approved these changes
Apr 25, 2025
Member
deyankiteworks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and LGTM.
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
ff894e1 to
f48288b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
With this PR, we can run selective tests using predefined users.
Tests that cannot be run (at least for now):
What happens when using predefined users?
How to Run Tests
Available configs:
PREDEFINED_USERS: (true|false)PREDEFINED_USERS_FILE: (path to a JSON file mapping predefined users)Predefined users JSON file example:
Important
The user keys MUST be the defined ones only
Available keys:
Required user properties:
Example mapping:
{ "alice": { "id": "einstein", "displayName": "Albert Einstein", "password": "relativity", "email": "einstein@example.org" }, "brian": { "id": "marie", "displayName": "Marie Skłodowska Curie", "password": "radioactivity", "email": "marie@example.org" }, "carol": { "id": "moss", "displayName": "Maurice Moss", "password": "vista", "email": "moss@example.org" } }Note
Only the test scenarios tagged with
@predefined-userswork with predefined users.Command:
Related Issue
Motivation and Context
To be able to run webUI e2e tests with pre-production servers
How Has This Been Tested?
Types of changes