[full-ci] feat(web-client): strip base path #13545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
LukasHirt
force-pushed
the
feat/strip-base-path
branch
from
0d6535d to
f5bd823
Compare
LukasHirt
changed the title
Added a new logic to the WebDAV client to strip the prefix from the path if it is present. Previously, only `/dav/` prefix would be stripped when parsing the response. Now, it will strip all the parts of the base remote URL. For example, if the base remote URL is `https://example.com/my/nested/path/`, it will strip the `/my/nested/path/dav/` prefix.
LukasHirt
force-pushed
the
feat/strip-base-path
branch
from
f5bd823 to
1946166
Compare
Collaborator
Author
|
I'm omitting test for this as we currently haven't got unit tests for the webdav client at all. |
mzner
approved these changes
Feb 12, 2026
|
mzner
reviewed
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new logic to the WebDAV client to strip the prefix from the path if it is present. Previously, only
/dav/prefix would be stripped when parsing the response. Now, it will strip all the parts of the base remote URL. For example, if the base remote URL is[https://example.com/my/nested/path/](https://example.com/my/nested/path/%60), it will strip the/my/nested/path/dav/prefix.Motivation and Context
Support deployments where base server URL is using nested paths.
How Has This Been Tested?
Types of changes