Skip to content

fix(web-runtime): [OCISDEV-909] add explicit sizes to logo assets#13834

Merged
LukasHirt merged 1 commit into
masterfrom
fix/logo-assets
Jun 4, 2026
Merged

fix(web-runtime): [OCISDEV-909] add explicit sizes to logo assets#13834
LukasHirt merged 1 commit into
masterfrom
fix/logo-assets

Conversation

@LukasHirt
Copy link
Copy Markdown
Collaborator

Description

The topbar logo was not visible in Firefox because the SVG files lacked explicit width and height attributes. Firefox requires these attributes to establish intrinsic dimensions when loading SVGs via <img>; without them it renders the image as 0×0. Chrome infers the dimensions from viewBox alone.

Motivation and Context

Logo is correctly rendered in all browsers.

How Has This Been Tested?

  • test environment: macos, chrome, firefox, safari
  • test case 1: open web UI and check whether the logo is rendered

@LukasHirt LukasHirt self-assigned this Jun 2, 2026
@kw-security
Copy link
Copy Markdown

kw-security commented Jun 2, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@mzner
Copy link
Copy Markdown
Contributor

mzner commented Jun 2, 2026

@LukasHirt Do we want to include the ticket number into the branch name for future automation?

Also, should we add the Jira ticket into the description to help QA find the corresponding ticket? What do you think?

@LukasHirt
Copy link
Copy Markdown
Collaborator Author

Do we want to include the ticket number into the branch name for future automation?

Shouldn't it be sufficient in the commit message? At least e.g. for the git jira app it is enough. I personally like to keep branch names simple so that I can easily switch between them…

should we add the Jira ticket into the description to help QA find the corresponding ticket

Sure, why not.

The topbar logo was not visible in Firefox because the SVG files lacked
explicit `width` and `height` attributes. Firefox requires these
attributes to establish intrinsic dimensions when loading SVGs
via `<img>`; without them it renders the image as 0×0. Chrome infers
the dimensions from `viewBox` alone.

Signed-off-by: Lukas Hirt <info@hirt.cz>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 3, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
39.9% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud

@LukasHirt LukasHirt merged commit e6bbc45 into master Jun 4, 2026
20 of 21 checks passed
@LukasHirt LukasHirt deleted the fix/logo-assets branch June 4, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants