fix(web-runtime): [OCISDEV-909] add explicit sizes to logo assets#13834
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
@LukasHirt Do we want to include the ticket number into the branch name for future automation? Also, should we add the Jira ticket into the description to help QA find the corresponding ticket? What do you think? |
Shouldn't it be sufficient in the commit message? At least e.g. for the git jira app it is enough. I personally like to keep branch names simple so that I can easily switch between them…
Sure, why not. |
6fdff8d to
132399a
Compare
The topbar logo was not visible in Firefox because the SVG files lacked explicit `width` and `height` attributes. Firefox requires these attributes to establish intrinsic dimensions when loading SVGs via `<img>`; without them it renders the image as 0×0. Chrome infers the dimensions from `viewBox` alone. Signed-off-by: Lukas Hirt <info@hirt.cz>
132399a to
eaab0a3
Compare
|


Description
The topbar logo was not visible in Firefox because the SVG files lacked explicit
widthandheightattributes. Firefox requires these attributes to establish intrinsic dimensions when loading SVGs via<img>; without them it renders the image as 0×0. Chrome infers the dimensions fromviewBoxalone.Motivation and Context
Logo is correctly rendered in all browsers.
How Has This Been Tested?