Skip to content

Add public link display#1670

Merged
DeepDiver1975 merged 1 commit intomasterfrom
feature/public-link-display
Aug 3, 2019
Merged

Add public link display#1670
DeepDiver1975 merged 1 commit intomasterfrom
feature/public-link-display

Conversation

@DeepDiver1975
Copy link
Copy Markdown
Member

@DeepDiver1975 DeepDiver1975 commented Jul 31, 2019 •
edited
Loading

Description

Adding public link display - following cases are implemented:

  • single file (same as folder)
  • single file with password (same as folder)
  • readonly folder
  • readonly folder with password
  • full access folder
  • full access folder with password
  • upload only folder
  • upload only folder with password

Related Issue

How Has This Been Tested?

Screenshots (if appropriate):

Screenshot from 2019-08-01 17-36-17
Screenshot from 2019-08-01 12-30-17

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 self-assigned this Jul 31, 2019
@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jul 31, 2019

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4489/12

20190731-141813-671.png
20190731-141813-830.png

@DeepDiver1975 DeepDiver1975 force-pushed the feature/public-link-display branch 2 times, most recently from abb96bb to 73a4754 Compare August 1, 2019 15:34
@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Aug 1, 2019

💥 Acceptance tests webUINotifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4503/5

20190801-154104-257.png
20190801-154128-882.png
20190801-154153-543.png
20190801-154218-553.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Aug 1, 2019

💥 Acceptance tests webUIFavorites failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4503/2

20190801-153855-036.png
20190801-153943-083.png
20190801-154030-824.png
20190801-154118-700.png
20190801-154154-828.png
20190801-154223-050.png
20190801-154241-526.png
20190801-154259-465.png
20190801-154420-482.png
20190801-154541-614.png
20190801-154609-826.png
20190801-154648-535.png
20190801-154717-125.png
20190801-154745-852.png
20190801-154824-081.png
20190801-154852-157.png
20190801-154920-119.png
20190801-154948-184.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Aug 1, 2019

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4503/13

20190801-154002-705.png
20190801-154046-642.png
20190801-154121-026.png
20190801-154154-754.png
20190801-154228-482.png
20190801-154302-016.png
20190801-154456-947.png
20190801-154457-078.png
20190801-154535-705.png
20190801-154535-768.png
20190801-155204-551.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Aug 1, 2019

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4503/12

20190801-154111-595.png
20190801-154155-880.png
20190801-154230-304.png
20190801-154313-490.png
20190801-154347-809.png
20190801-154421-925.png
20190801-154619-036.png
20190801-154619-266.png
20190801-154658-491.png
20190801-154658-623.png

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Aug 1, 2019

💥 Acceptance tests webUIFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4503/3

20190801-154916-828.png
20190801-154917-172.png
20190801-154956-853.png
20190801-154957-236.png
20190801-155044-675.png
20190801-155044-939.png
20190801-155124-390.png
20190801-155124-700.png
20190801-155213-539.png
20190801-155213-772.png
20190801-155254-795.png
20190801-155255-117.png
20190801-155344-468.png
20190801-155344-729.png
20190801-155428-094.png
20190801-155428-401.png
20190801-155524-135.png
20190801-155524-533.png
20190801-155622-622.png
20190801-155622-863.png
20190801-155706-616.png
20190801-155706-976.png
20190801-155750-243.png
20190801-155750-490.png
20190801-155831-863.png
20190801-155832-085.png
20190801-155913-635.png
20190801-155914-189.png

@DeepDiver1975 DeepDiver1975 changed the title Add public link display for single files Add public link display Aug 2, 2019
@DeepDiver1975 DeepDiver1975 force-pushed the feature/public-link-display branch from 73a4754 to 582d413 Compare August 2, 2019 06:37
LukasHirt
LukasHirt requested changes Aug 2, 2019
View reviewed changes
Comment thread apps/files/src/components/FilesAppBar.vue
Comment thread apps/files/src/components/PublicLinks/PublicLink.vue Outdated
<h2 class="oc-login-card-title"><translate>This resource is password-protected.</translate></h2>

<oc-text-input type="password" v-model="password" :placeholder="passwordPlaceholder"></oc-text-input>
<br>
Copy link
Copy Markdown
Collaborator

@LukasHirt LukasHirt Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove those br tags and replace it with a margin class pls in the input. This would make it harder to theme.

Copy link
Copy Markdown
Member Author

@DeepDiver1975 DeepDiver1975 Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can I apply the margin? which class shall I use? THX

Copy link
Copy Markdown
Collaborator

@LukasHirt LukasHirt Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For adding uk-margin- and then size (small, medium, large, xlarge or without a size and it will get default) then you can also assign direction (top, right, bottom, left or no direction for giving it to all of them). Work also for removing margin uk-margin-remove- and again direction or no direction for all of them.

Comment thread src/plugins/mediaSource.js
el.setAttribute('src', 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII=')

this.mediaSource(binding.value).then(dataImage => {
_mediaSource(binding.value).then(dataImage => {
Copy link
Copy Markdown
Collaborator

@LukasHirt LukasHirt Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have been done by introducing vnode as param next to binding and then replacing this with vnode.context but I guess it doesn't really matter if it's that or this solution.

Copy link
Copy Markdown
Member Author

@DeepDiver1975 DeepDiver1975 Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not deeper look into vue plugins - the only thing I know - this.mediaSource does not work ;-)

Copy link
Copy Markdown
Collaborator

@LukasHirt LukasHirt Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no worries, just mentioning it as another option how to do that 😉

@DeepDiver1975 DeepDiver1975 force-pushed the feature/public-link-display branch from 582d413 to 7fec912 Compare August 2, 2019 08:25
@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Aug 2, 2019

💥 Acceptance tests webUITrashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4512/10

20190802-083754-355.png
20190802-083837-692.png

LukasHirt
LukasHirt approved these changes Aug 2, 2019
View reviewed changes
Comment thread apps/files/src/components/PublicLinks/PublicLink.vue Outdated
Comment thread apps/files/src/components/PublicLinks/PublicLink.vue Outdated
@LukasHirt
Copy link
Copy Markdown
Collaborator

LukasHirt commented Aug 2, 2019

@DeepDiver1975 I don't really like the margin for all directions on the button. Rather use just the direction you need. I proposed you there small change. If you don't want them, feel free to merge without them 😉

@DeepDiver1975 DeepDiver1975 force-pushed the feature/public-link-display branch from ecb7dee to 4039975 Compare August 2, 2019 12:34
@DeepDiver1975 DeepDiver1975 merged commit dd6b433 into master Aug 3, 2019
@delete-merged-branch delete-merged-branch Bot deleted the feature/public-link-display branch August 3, 2019 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@lordelix lordelix Awaiting requested review from lordelix

Assignees

@DeepDiver1975 DeepDiver1975

Labels

Status:In-Progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DeepDiver1975 @ownclouders @LukasHirt