Skip to content

Rename all Phoenix occurences to Web#4443

Merged
LukasHirt merged 16 commits intomasterfrom
rename-to-web
Dec 11, 2020
Merged

Rename all Phoenix occurences to Web#4443
LukasHirt merged 16 commits intomasterfrom
rename-to-web

Conversation

@LukasHirt
Copy link
Copy Markdown
Collaborator

@LukasHirt LukasHirt commented Dec 9, 2020 •
edited by micbar
Loading

Open tasks:

  • Rename the repo itself
  • Rename "ocis-phoenix" in ocis repo (ocis PR)
  • Demo instance needs to be renamed (maybe could be done later not to block this PR - create task in jira?)
  • Rename phoenix.baseUrl (oc10 PR)
  • Rename Phoenix on transifex

@update-docs
Copy link
Copy Markdown

update-docs bot commented Dec 9, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

phil-davis
phil-davis reviewed Dec 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few observations - this will take a bit of coordination :)

@LukasHirt LukasHirt self-assigned this Dec 9, 2020
@phil-davis phil-davis mentioned this pull request Dec 9, 2020
Merged
11 tasks
@LukasHirt LukasHirt marked this pull request as ready for review December 10, 2020 10:58
micbar
micbar reviewed Dec 10, 2020
View reviewed changes
micbar
micbar reviewed Dec 10, 2020
View reviewed changes
micbar
micbar reviewed Dec 10, 2020
View reviewed changes
micbar
micbar reviewed Dec 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some inconsistencies between

WEB_CONFIG and WEB_WEBUI_CONFIG

can you check them again?

This was referenced Dec 11, 2020
Closed
Closed
@wkloucek
Copy link
Copy Markdown
Contributor

wkloucek commented Dec 11, 2020

#4471 has been merged, please rebase onto latest master do make CI green

@LukasHirt
Copy link
Copy Markdown
Collaborator Author

LukasHirt commented Dec 11, 2020

@micbar Correct web config vars used and rebased - ready for re-review 🙂

@LukasHirt
Copy link
Copy Markdown
Collaborator Author

LukasHirt commented Dec 11, 2020

Two config vars in drone still stayed PHOENIX_WEB_CONFIG - that needs to stay until changing the vars in ocis-web

micbar
micbar approved these changes Dec 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine so far.

@LukasHirt LukasHirt merged commit a528eb1 into master Dec 11, 2020
@LukasHirt LukasHirt deleted the rename-to-web branch December 11, 2020 14:57
ownclouders pushed a commit that referenced this pull request Dec 11, 2020
commit a528eb1
77a9dde 
Merge: d34e904 4995f45
Author: Lukas Hirt <lhirt@owncloud.com>
Date:   Fri Dec 11 15:57:25 2020 +0100

    Merge pull request #4443 from owncloud/rename-to-web
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis left review comments

+2 more reviewers

@kulmann kulmann kulmann left review comments

@micbar micbar micbar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LukasHirt LukasHirt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LukasHirt @wkloucek @phil-davis @kulmann @micbar