[Tests-Only] Add webUI tests for preview of image files with media viewer#4570
Merged
jasson99 merged 1 commit intoowncloud:masterfrom Jan 4, 2021
Merged
[Tests-Only] Add webUI tests for preview of image files with media viewer#4570jasson99 merged 1 commit intoowncloud:masterfrom
jasson99 merged 1 commit intoowncloud:masterfrom
Conversation
SwikritiT
changed the title
individual-it
requested review from
Talank,
dpakach,
haribhandari07,
jasson99 and
swoichha
Comment on lines
+82
to
+92
| Scenario: preview of png file with media viewer is possible | ||
| Given user "user1" has uploaded file "testavatar.png" to "testavatar.png" | ||
| And user "user1" has logged in using the webUI | ||
| When the user views the file "testavatar.png" in the media viewer using the webUI | ||
| Then the file "testavatar.png" should be displayed in the media viewer webUI | ||
|
|
||
| Scenario: preview of jpeg with media viewer is possible | ||
| Given user "user1" has uploaded file "testavatar.jpeg" to "testavatar.jpeg" | ||
| And user "user1" has logged in using the webUI | ||
| When the user views the file "testavatar.jpeg" in the media viewer using the webUI | ||
| Then the file "testavatar.jpeg" should be displayed in the media viewer webUI |
Contributor
There was a problem hiding this comment.
You can use data table in the first scenario of this file. @Talank please assist her
Contributor
There was a problem hiding this comment.
Also please remove tests/acceptance/filesForUpload/testavatar.jpeg from git
Contributor
There was a problem hiding this comment.
I think including both of these scenarios in a single scenario outline will be nice.
Talank
suggested changes
Dec 30, 2020
dpakach
reviewed
Dec 30, 2020
SwikritiT
force-pushed
the
imageMediaViewer
branch
from
9e0275a to
1acfe40
Compare
Member
individual-it
left a comment
individual-it
left a comment
There was a problem hiding this comment.
LGTM
please squash the commits
SwikritiT
force-pushed
the
imageMediaViewer
branch
from
f78755d to
3276cf5
Compare
SwikritiT
changed the title
Contributor
Author
|
@individual-it I think we don't have |
Member
|
@SwikritiT you can ether:
but actually you should not need to upload files at all. You automatically should have all files in the test-user context from https://github.com/owncloud/testing/tree/master/data/webUISkeleton |
Contributor
Author
seems like there no file with |
individual-it
approved these changes
Dec 31, 2020
SwikritiT
force-pushed
the
imageMediaViewer
branch
from
01aabf2 to
2ae38aa
Compare
SwikritiT
force-pushed
the
imageMediaViewer
branch
from
2ae38aa to
6e3940f
Compare
Talank
approved these changes
Dec 31, 2020
SwikritiT
force-pushed
the
imageMediaViewer
branch
5 times, most recently
from
d9e5cef to
1c4e77b
Compare
SwikritiT
force-pushed
the
imageMediaViewer
branch
from
1c4e77b to
7bdd6fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add webUI tests for preview of jpeg and png file with media viewer
Related Issue
-Fixes #4296
How Has This Been Tested?
🤖
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: