Closed
Conversation
This title appears before the config title is loaded.
Show simple spinner (similar to ocSpiner) if it takes too long to load (> 1s); Show error message when failed to load.
Allow img instead of icon Ensure canBeDefault is honored
If there's an image, it takes precedence over icon (which always has a default)
Merged
|
SonarCloud Quality Gate failed. |
Contributor
|
Results for oCISSharingPubExpAndRoles https://drone.owncloud.com/owncloud/web/20628/66/1
|
Contributor
|
Closing as stale, I'll take over on a separate branch. Thanks @phil-davis for the initiative |
Contributor
Author
|
@pascalwengerter thanks |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebase of #5985 and I have requested [full-ci] to see what are all the acceptance tests that are failing.
I will look tomorrow morning and see what is a "real" test fail. Then we can sort out if any tests and/or code need adjusting.