Fix local syntax normalization#46
Merged
Merged
Conversation
Signed-off-by: alanechang <alanechang@janestreet.com>
Signed-off-by: alanechang <alanechang@janestreet.com>
goldfirere
approved these changes
Dec 6, 2023
goldfirere
left a comment
goldfirere
left a comment
There was a problem hiding this comment.
I see no changes to tests... but if I understand correctly, this just fixes the tests that are broken in jane. If that understanding is correct, please merge. Thanks!
Author
|
Yes, this PR fixes the tests currently broken in I don't yet have write access in this repo necessary to merge the PR. Would be great for someone with the proper permissions to merge this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some bad interactions between #42 and #44. This PR fixes the local syntax normalization logic by stop generating jane syntax location attributes.