Fix put() value type handling and KeyNotFound consistency#19
Merged
merlimat merged 1 commit intooxia-db:mainfrom Apr 16, 2026
Merged
Fix put() value type handling and KeyNotFound consistency#19merlimat merged 1 commit intooxia-db:mainfrom
merlimat merged 1 commit intooxia-db:mainfrom
Conversation
…db#7, oxia-db#9) Bug oxia-db#7: put() used `type(value) is str` (rejects str subclasses) and `bytes(str(value), ...)` (redundant str()). Non-str/non-bytes values were forwarded to protobuf, erroring deep in serialization. Extracted _coerce_value(): isinstance checks, clear TypeError for invalid types, str.encode() instead of redundant bytes(str(...)). Bug oxia-db#9: `raise oxia.ex.KeyNotFound` (class) was inconsistent with the rest of the file which uses `raise KeyNotFound()` (instance). Both are legal Python but the instance form is conventional. Bug oxia-db#10 (non-atomic assignment swap) was a false positive — the existing _parse_assignments already holds self._lock during both the clear and repopulate. Dropped from the fix list. Signed-off-by: Matteo Merli <mmerli@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug #7: put() used `type(value) is str` (rejects str subclasses) and `bytes(str(value), ...)` (redundant). Non-str/non-bytes values errored deep in protobuf serialization.
Extracted `_coerce_value()`: isinstance checks, clear TypeError for invalid types.
Bug #9: `raise oxia.ex.KeyNotFound` (class) → `raise oxia.ex.KeyNotFound()` (instance) for consistency.