Add code coverage reporting to CI#9
Merged
merlimat merged 2 commits intooxia-db:mainfrom Apr 16, 2026
Merged
Conversation
- Add pytest-cov to dev dependencies - Configure coverage in pyproject.toml: measure oxia package, omit generated proto files, show missing lines - Update CI workflow to run tests with coverage, upload XML artifact, and post a coverage summary comment on PRs - Add coverage.xml and htmlcov/ to .gitignore Signed-off-by: Matteo Merli <mmerli@apache.org>
The orgoro/coverage action requires write access to pull-requests, which is not available for fork PRs. Coverage is still visible in the CI log (term-missing) and as a downloadable XML artifact. Signed-off-by: Matteo Merli <mmerli@apache.org>
merlimat
force-pushed
the
add-coverage-reporting
branch
from
3425873 to
264f3d7
Compare
merlimat
added a commit
to merlimat/oxia-client-python
that referenced
this pull request
Apr 16, 2026
…db#7, oxia-db#9) Bug oxia-db#7: put() used `type(value) is str` (rejects str subclasses) and `bytes(str(value), ...)` (redundant str()). Non-str/non-bytes values were forwarded to protobuf, erroring deep in serialization. Extracted _coerce_value(): isinstance checks, clear TypeError for invalid types, str.encode() instead of redundant bytes(str(...)). Bug oxia-db#9: `raise oxia.ex.KeyNotFound` (class) was inconsistent with the rest of the file which uses `raise KeyNotFound()` (instance). Both are legal Python but the instance form is conventional. Bug oxia-db#10 (non-atomic assignment swap) was a false positive — the existing _parse_assignments already holds self._lock during both the clear and repopulate. Dropped from the fix list. Signed-off-by: Matteo Merli <mmerli@apache.org>
2 tasks
merlimat
added a commit
to merlimat/oxia-client-python
that referenced
this pull request
Apr 16, 2026
…db#7, oxia-db#9) Bug oxia-db#7: put() used `type(value) is str` (rejects str subclasses) and `bytes(str(value), ...)` (redundant str()). Non-str/non-bytes values were forwarded to protobuf, erroring deep in serialization. Extracted _coerce_value(): isinstance checks, clear TypeError for invalid types, str.encode() instead of redundant bytes(str(...)). Bug oxia-db#9: `raise oxia.ex.KeyNotFound` (class) was inconsistent with the rest of the file which uses `raise KeyNotFound()` (instance). Both are legal Python but the instance form is conventional. Bug oxia-db#10 (non-atomic assignment swap) was a false positive — the existing _parse_assignments already holds self._lock during both the clear and repopulate. Dropped from the fix list. Signed-off-by: Matteo Merli <mmerli@apache.org>
merlimat
added a commit
that referenced
this pull request
Apr 16, 2026
… (#19) Bug #7: put() used `type(value) is str` (rejects str subclasses) and `bytes(str(value), ...)` (redundant str()). Non-str/non-bytes values were forwarded to protobuf, erroring deep in serialization. Extracted _coerce_value(): isinstance checks, clear TypeError for invalid types, str.encode() instead of redundant bytes(str(...)). Bug #9: `raise oxia.ex.KeyNotFound` (class) was inconsistent with the rest of the file which uses `raise KeyNotFound()` (instance). Both are legal Python but the instance form is conventional. Bug #10 (non-atomic assignment swap) was a false positive — the existing _parse_assignments already holds self._lock during both the clear and repopulate. Dropped from the fix list. Signed-off-by: Matteo Merli <mmerli@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pytest-covto dev dependenciespyproject.toml: measureoxiapackage, omit generated proto files, show missing lines--cov, uploadcoverage.xmlas artifact, and post a coverage summary comment on PRs (viaorgoro/coverage)coverage.xmlandhtmlcov/to.gitignoreCurrent coverage on
main(measured locally):Test plan
uv run pytest --cov --cov-report=term-missingruns locally and prints the table--cov-report=xmlgeneratescoverage.xml