Skip to content

Allow creating stopped instance. #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Allow creating stopped instance. #1147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32898c2
Bump omicron version and regen client.
luqmana Sep 8, 2022
c058314
Add checkbox to choose whether to start instance after creation.
luqmana Sep 8, 2022
70b1fc5
gen-api
luqmana Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion OMICRON_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
f2e6237e57a36873fc748b6ecd9e42b8ef208c88
d1fc7da4c01c4e7b17c7b3319df712390fae68fa
7 changes: 7 additions & 0 deletions app/forms/instance-create.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
import { GiB } from '@oxide/util'

import type { DiskTableItem } from 'app/components/form'
import { CheckboxField } from 'app/components/form'
import { FullPageForm } from 'app/components/form'
import { DiskSizeField } from 'app/components/form'
import {
Expand Down Expand Up @@ -72,6 +73,8 @@ const values: InstanceCreateInput = {
* We actually don't care about this value outside of that.
*/
networkInterfaceType: 'default',

start: true,
}

export default function CreateInstanceForm({
Expand Down Expand Up @@ -166,6 +169,7 @@ export default function CreateInstanceForm({
...values.disks,
],
externalIps: [{ type: 'ephemeral' }],
start: values.start,
},
})
})
Expand All @@ -176,6 +180,9 @@ export default function CreateInstanceForm({
>
<NameField id="name" />
<DescriptionField id="description" />
<CheckboxField id="start-instance" name="start" label="Start Instance">
Start Instance
</CheckboxField>
Copy link
Collaborator

@david-crespo david-crespo Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As a followup we might want to add a tooltip or something explaining what this means in more detail, but this is fine. We need to do that in a million places. Maybe we could add a description that says "If unchecked, the instance will be created in the stopped state" or something? Doesn't seem too important, really.

Copy link
Collaborator

@david-crespo david-crespo Sep 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm just kidding, I just saw the screenshot and remembered it's a checkbox. I don't think we have a nice way of putting a description on a checkbox.

Copy link
Contributor Author

@luqmana luqmana Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the attached label perhaps?


<Divider />

Expand Down
62 changes: 33 additions & 29 deletions libs/api/__generated__/Api.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion libs/api/__generated__/OMICRON_VERSION
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.