Update OMICRON_VERSION and regenerate api #1982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
app/forms/floating-ip-create.tsx
Outdated
| <TextField | ||
| name="address" | ||
| name="ip" | ||
| label="Address" |
Collaborator
There was a problem hiding this comment.
This hasn’t gone out to any real users, so we should just name it whatever is best. Even if it had I think I’d say the same thing. That may still be “Address”, but consistency wouldn’t be the reason.
I like being the same as the API where possible, so maybe “IP” or “IP address” is worth considering.
Contributor
Author
There was a problem hiding this comment.
I think IP address works well and makes it clear (and maybe more clear than just IP); will switch to that, but happy to update again if we want it to map precisely to the API.
david-crespo
approved these changes
Feb 27, 2024
charliepark
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 27, 2024
oxidecomputer/console@80f1167...e991ec5 * [e991ec5c](oxidecomputer/console@e991ec5c) oxidecomputer/console#1982 * [8e247f28](oxidecomputer/console@8e247f28) get rid of @oxide/gen alias * [7d936d7e](oxidecomputer/console@7d936d7e) oxidecomputer/console#1981 * [b9a6051d](oxidecomputer/console@b9a6051d) delete unused app/table/headers * [0b330247](oxidecomputer/console@0b330247) remove barrel files in app/pages * [e53942ce](oxidecomputer/console@e53942ce) remove dot-path-fix vite plugin while we’re not using it * [1af82bff](oxidecomputer/console@1af82bff) use vite-tsconfig-paths insead of my old manual thing * [0f2411e8](oxidecomputer/console@0f2411e8) oxidecomputer/console#1962 * [bd64c620](oxidecomputer/console@bd64c620) oxidecomputer/console#1978 * [4388a92a](oxidecomputer/console@4388a92a) change pt-2 back to py-2 on AccordionItem * [a0921bd6](oxidecomputer/console@a0921bd6) move msw handlers out of mock-api barrel file * [6ab60b9b](oxidecomputer/console@6ab60b9b) update references to libs/ everywhere * [9b4a6e0f](oxidecomputer/console@9b4a6e0f) move classed out of util barrel * [d731de2b](oxidecomputer/console@d731de2b) oxidecomputer/console#1977 * [6c5883d9](oxidecomputer/console@6c5883d9) oxidecomputer/console#1976 * [6de56b15](oxidecomputer/console@6de56b15) oxidecomputer/console#1975 * [bbf019ee](oxidecomputer/console@bbf019ee) oxidecomputer/console#1973 * [b9c1892d](oxidecomputer/console@b9c1892d) oxidecomputer/console#1974 * [e2e56d87](oxidecomputer/console@e2e56d87) Revert `try .git-blame-ignore-revs`. don’t like it * [1745a752](oxidecomputer/console@1745a752) try .git-blame-ignore-revs * [4bfd2275](oxidecomputer/console@4bfd2275) oxidecomputer/console#1971 * [cb109cba](oxidecomputer/console@cb109cba) oxidecomputer/console#1968 * [264e2cd1](oxidecomputer/console@264e2cd1) oxidecomputer/console#1969 * [3ec255f9](oxidecomputer/console@3ec255f9) Revert `Shuffle @oxide/pagination files (oxidecomputer/console#1970)` * [3eebf491](oxidecomputer/console@3eebf491) oxidecomputer/console#1970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated OMICRON_VERSION and ran
npm run gen-api.Also updated
oxide.ts, in oxidecomputer/oxide.ts#229