Skip to content

Conversation

@david-crespo
Copy link
Collaborator

@david-crespo david-crespo commented Mar 4, 2024

@vercel
Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Mar 7, 2024 4:59pm

@david-crespo
Copy link
Collaborator Author

david-crespo commented Mar 4, 2024

Ok, I've found the catch. I bet the size can be cut substantially without this downside.

image

We never actually show the image at full zoom, so it doesn't look that bad in context. But it's still noticeable.

@david-crespo david-crespo marked this pull request as draft March 4, 2024 17:47
@david-crespo david-crespo changed the title Run rack image through tinypng, cut size by 2/3 Optimize rack image Mar 4, 2024
@david-crespo
Copy link
Collaborator Author

I notice what I think are compression artifacts even on the main copy — I wonder if we'd see better results if we started from an original uncompressed version.

image

@david-crespo david-crespo marked this pull request as ready for review March 7, 2024 17:03
@david-crespo david-crespo enabled auto-merge (squash) March 7, 2024 17:05
@david-crespo david-crespo merged commit 84caede into main Mar 7, 2024
@david-crespo david-crespo deleted the optimize-rack-image branch March 7, 2024 17:08
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Mar 21, 2024
oxidecomputer/console@784e8aa...7c96844

* [7c968443](oxidecomputer/console@7c968443) oxidecomputer/console#2083
* [b844a42c](oxidecomputer/console@b844a42c) oxidecomputer/console#2078
* [47835ee3](oxidecomputer/console@47835ee3) oxidecomputer/console#2086
* [c4ddebc2](oxidecomputer/console@c4ddebc2) oxidecomputer/console#2082
* [530a0997](oxidecomputer/console@530a0997) upload-artifact@v4 requires unique filenames for each run in matrix
* [b996c34c](oxidecomputer/console@b996c34c) bump actions/upload-artifact to v4
* [bc51f530](oxidecomputer/console@bc51f530) bump API to latest main
* [743da3b0](oxidecomputer/console@743da3b0) oxidecomputer/console#2080
* [7596d633](oxidecomputer/console@7596d633) oxidecomputer/console#2073
* [65531bff](oxidecomputer/console@65531bff) oxidecomputer/console#2074
* [4d226cd3](oxidecomputer/console@4d226cd3) oxidecomputer/console#1891
* [7490104a](oxidecomputer/console@7490104a) update readme with cool new preview URL
* [a2218994](oxidecomputer/console@a2218994) oxidecomputer/console#2066
* [641ebe85](oxidecomputer/console@641ebe85) oxidecomputer/console#2061
* [1bb8dd3a](oxidecomputer/console@1bb8dd3a) oxidecomputer/console#2055
* [41dd9f06](oxidecomputer/console@41dd9f06) oxidecomputer/console#2059
* [04692802](oxidecomputer/console@04692802) oxidecomputer/console#2048
* [8c30305e](oxidecomputer/console@8c30305e) oxidecomputer/console#2050
* [53709d2a](oxidecomputer/console@53709d2a) oxidecomputer/console#2046
* [84caede7](oxidecomputer/console@84caede7) oxidecomputer/console#2026
* [bca9f42a](oxidecomputer/console@bca9f42a) oxidecomputer/console#2045
* [09e5f713](oxidecomputer/console@09e5f713) oxidecomputer/console#2043
* [d780e5d8](oxidecomputer/console@d780e5d8) fix casing on floating IP attach/detach toasts
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Mar 21, 2024
oxidecomputer/console@784e8aa...7c96844

* [7c968443](oxidecomputer/console@7c968443)
oxidecomputer/console#2083
* [b844a42c](oxidecomputer/console@b844a42c)
oxidecomputer/console#2078
* [47835ee3](oxidecomputer/console@47835ee3)
oxidecomputer/console#2086
* [c4ddebc2](oxidecomputer/console@c4ddebc2)
oxidecomputer/console#2082
* [530a0997](oxidecomputer/console@530a0997)
upload-artifact@v4 requires unique filenames for each run in matrix
* [b996c34c](oxidecomputer/console@b996c34c)
bump actions/upload-artifact to v4
* [bc51f530](oxidecomputer/console@bc51f530)
bump API to latest main
* [743da3b0](oxidecomputer/console@743da3b0)
oxidecomputer/console#2080
* [7596d633](oxidecomputer/console@7596d633)
oxidecomputer/console#2073
* [65531bff](oxidecomputer/console@65531bff)
oxidecomputer/console#2074
* [4d226cd3](oxidecomputer/console@4d226cd3)
oxidecomputer/console#1891
* [7490104a](oxidecomputer/console@7490104a)
update readme with cool new preview URL
* [a2218994](oxidecomputer/console@a2218994)
oxidecomputer/console#2066
* [641ebe85](oxidecomputer/console@641ebe85)
oxidecomputer/console#2061
* [1bb8dd3a](oxidecomputer/console@1bb8dd3a)
oxidecomputer/console#2055
* [41dd9f06](oxidecomputer/console@41dd9f06)
oxidecomputer/console#2059
* [04692802](oxidecomputer/console@04692802)
oxidecomputer/console#2048
* [8c30305e](oxidecomputer/console@8c30305e)
oxidecomputer/console#2050
* [53709d2a](oxidecomputer/console@53709d2a)
oxidecomputer/console#2046
* [84caede7](oxidecomputer/console@84caede7)
oxidecomputer/console#2026
* [bca9f42a](oxidecomputer/console@bca9f42a)
oxidecomputer/console#2045
* [09e5f713](oxidecomputer/console@09e5f713)
oxidecomputer/console#2043
* [d780e5d8](oxidecomputer/console@d780e5d8)
fix casing on floating IP attach/detach toasts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants