Skip to content

Conversation

@david-crespo
Copy link
Collaborator

Named exports are a best practice. Bundlers prefer them, and default exports have no canonical name when imported, making things harder to search for. The exceptions I left:

  • Config files for Vite and Playwright, which probably require it
  • Terminal and TimeSeriesChart, which are imported through dynamic import(). To import a named export through import(), you have to do the following, which is distasteful.
    const TimeSeriesChart = React.lazy(() =>
      import('./TimeSeriesChart').then((m) => ({ default: m.TimeSeriesChart }))
    )

@vercel
Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Mar 8, 2024 10:51pm

@david-crespo david-crespo merged commit 8c30305 into main Mar 8, 2024
@david-crespo david-crespo deleted the no-default-exports branch March 8, 2024 23:37
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Mar 21, 2024
oxidecomputer/console@784e8aa...7c96844

* [7c968443](oxidecomputer/console@7c968443) oxidecomputer/console#2083
* [b844a42c](oxidecomputer/console@b844a42c) oxidecomputer/console#2078
* [47835ee3](oxidecomputer/console@47835ee3) oxidecomputer/console#2086
* [c4ddebc2](oxidecomputer/console@c4ddebc2) oxidecomputer/console#2082
* [530a0997](oxidecomputer/console@530a0997) upload-artifact@v4 requires unique filenames for each run in matrix
* [b996c34c](oxidecomputer/console@b996c34c) bump actions/upload-artifact to v4
* [bc51f530](oxidecomputer/console@bc51f530) bump API to latest main
* [743da3b0](oxidecomputer/console@743da3b0) oxidecomputer/console#2080
* [7596d633](oxidecomputer/console@7596d633) oxidecomputer/console#2073
* [65531bff](oxidecomputer/console@65531bff) oxidecomputer/console#2074
* [4d226cd3](oxidecomputer/console@4d226cd3) oxidecomputer/console#1891
* [7490104a](oxidecomputer/console@7490104a) update readme with cool new preview URL
* [a2218994](oxidecomputer/console@a2218994) oxidecomputer/console#2066
* [641ebe85](oxidecomputer/console@641ebe85) oxidecomputer/console#2061
* [1bb8dd3a](oxidecomputer/console@1bb8dd3a) oxidecomputer/console#2055
* [41dd9f06](oxidecomputer/console@41dd9f06) oxidecomputer/console#2059
* [04692802](oxidecomputer/console@04692802) oxidecomputer/console#2048
* [8c30305e](oxidecomputer/console@8c30305e) oxidecomputer/console#2050
* [53709d2a](oxidecomputer/console@53709d2a) oxidecomputer/console#2046
* [84caede7](oxidecomputer/console@84caede7) oxidecomputer/console#2026
* [bca9f42a](oxidecomputer/console@bca9f42a) oxidecomputer/console#2045
* [09e5f713](oxidecomputer/console@09e5f713) oxidecomputer/console#2043
* [d780e5d8](oxidecomputer/console@d780e5d8) fix casing on floating IP attach/detach toasts
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Mar 21, 2024
oxidecomputer/console@784e8aa...7c96844

* [7c968443](oxidecomputer/console@7c968443)
oxidecomputer/console#2083
* [b844a42c](oxidecomputer/console@b844a42c)
oxidecomputer/console#2078
* [47835ee3](oxidecomputer/console@47835ee3)
oxidecomputer/console#2086
* [c4ddebc2](oxidecomputer/console@c4ddebc2)
oxidecomputer/console#2082
* [530a0997](oxidecomputer/console@530a0997)
upload-artifact@v4 requires unique filenames for each run in matrix
* [b996c34c](oxidecomputer/console@b996c34c)
bump actions/upload-artifact to v4
* [bc51f530](oxidecomputer/console@bc51f530)
bump API to latest main
* [743da3b0](oxidecomputer/console@743da3b0)
oxidecomputer/console#2080
* [7596d633](oxidecomputer/console@7596d633)
oxidecomputer/console#2073
* [65531bff](oxidecomputer/console@65531bff)
oxidecomputer/console#2074
* [4d226cd3](oxidecomputer/console@4d226cd3)
oxidecomputer/console#1891
* [7490104a](oxidecomputer/console@7490104a)
update readme with cool new preview URL
* [a2218994](oxidecomputer/console@a2218994)
oxidecomputer/console#2066
* [641ebe85](oxidecomputer/console@641ebe85)
oxidecomputer/console#2061
* [1bb8dd3a](oxidecomputer/console@1bb8dd3a)
oxidecomputer/console#2055
* [41dd9f06](oxidecomputer/console@41dd9f06)
oxidecomputer/console#2059
* [04692802](oxidecomputer/console@04692802)
oxidecomputer/console#2048
* [8c30305e](oxidecomputer/console@8c30305e)
oxidecomputer/console#2050
* [53709d2a](oxidecomputer/console@53709d2a)
oxidecomputer/console#2046
* [84caede7](oxidecomputer/console@84caede7)
oxidecomputer/console#2026
* [bca9f42a](oxidecomputer/console@bca9f42a)
oxidecomputer/console#2045
* [09e5f713](oxidecomputer/console@09e5f713)
oxidecomputer/console#2043
* [d780e5d8](oxidecomputer/console@d780e5d8)
fix casing on floating IP attach/detach toasts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants