Add sidebar metadata#3302
Open
charliepark wants to merge 6 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
charliepark
commented
Jul 22, 2026
| routerRoutesColHelper.accessor('name', { | ||
| header: 'Name', | ||
| cell: (info) => ( | ||
| <LinkCell |
Contributor
Author
There was a problem hiding this comment.
Worth noting that currently we disable the edit button on the router route if the route is a VPC subnet. By making this a LinkCell, the route sidebar is openable, but we already prevent the user from modifying the route:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a number of forms and views contained within sidebars. In our designs, we have a Properties Table at the top of the sidebar including static metadata, like the ID, Created At, Updated At, (more on those three in a sec, but "etc. for now") details for the given resource. Not all of our sidebars currently include the relevant metadata.
This PR adds those
PropertiesTables to the sidebars throughout the app. A few examples …As you can see, every resource ends up having the three elements of ID, Created At, and Updated At. Part of this PR involves setting those as the defaults, with the easy addition of relevant-to-that-type-of-resource extra rows. This does make the metadata tables a little taller, and Crespo noted in #994 that we might want to figure out how to tighten up the tables, possibly by removing the Updated row. That's certainly an option if we feel like it's too tall.
The PR also updates a few of the resources to have LinkCells, where you can click on the name of the resource in the parent overview table and open the sidebar, without needing to click on the action button and then the "Edit" button from within the dropdown. This PR doesn't remove the existing
Editbutton in the action menu, even though there's a bit of redundancy there.Closes #994