Skip to content

Light up multicast_drop counter in dpd/swadm #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2025
Merged

Light up multicast_drop counter in dpd/swadm #89

merged 3 commits into from
Aug 7, 2025

Conversation

@zeeshanlakhani
Copy link
Contributor

@zeeshanlakhani zeeshanlakhani commented Aug 7, 2025 •
edited
Loading

Closes:

Includes:

  • Update packet-test.sh to list expected counters with swadm

Notes:

@zeeshanlakhani
Light up multicast_drop counter in dpd/swadm
fda386c 
Closes:
  * #86

Includes:
  * Update packet-test.sh to list expected counters with `swadm`

Notes:
  * Currently PR'ed against
    #88 counter(s) updates
Base automatically changed from counters to main August 7, 2025 15:48
Nieuwejaar
Nieuwejaar reviewed Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@Nieuwejaar Nieuwejaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure I'm not missing something... This is redundant because of the meta.drop_reason, which gets tallied in the main Ingress control, right?

@zeeshanlakhani
Copy link
Contributor Author

zeeshanlakhani commented Aug 7, 2025 •
edited
Loading

Just to make sure I'm not missing something... This is redundant because of the meta.drop_reason, which gets tallied in the main Ingress control, right?

Exactly @Nieuwejaar.

@zeeshanlakhani zeeshanlakhani merged commit 6e66652 into main Aug 7, 2025
6 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/drop-mcast-ctr-86 branch August 7, 2025 16:57
@zeeshanlakhani zeeshanlakhani mentioned this pull request Aug 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nieuwejaar Nieuwejaar Nieuwejaar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zeeshanlakhani @Nieuwejaar