Merged
Conversation
smklein
approved these changes
Apr 13, 2021
Contributor
smklein
left a comment
smklein
left a comment
There was a problem hiding this comment.
LGTM, though I think you might need to hit the tests with a TRYBUILD=overwrite hammer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if the Dropshot server was dropped prior to closing it, it would panic. This was intended to guide people to using
close()for graceful shutdown. I've now run into this a lot more in failing test suites, where it's way more disruptive than it is helpful because the program panics while panicking, and you're left with very little debug information. So I'm proposing that we do attempt a graceful shutdown inDrop. I don't consider this a breaking change because previously, a program that ran into this behavior would panic anyway.