fix #104 duplicated inline response type schemas#105
Merged
davepacheco merged 13 commits intomainfrom Apr 16, 2021
Merged
Conversation
ahl
approved these changes
Apr 16, 2021
| fn make_subschema_for<T: JsonSchema>( | ||
| gen: &mut schemars::gen::SchemaGenerator, | ||
| ) -> schemars::schema::Schema { | ||
| gen.subschema_for::<T>() |
Collaborator
There was a problem hiding this comment.
nice find; I hadn't seen that method previously
Collaborator
Author
There was a problem hiding this comment.
Heh, I only found it when digging into why non-top-level types did create references instead of inline schemas.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104.