Merged
Conversation
davepacheco
reviewed
Dec 6, 2024
Collaborator
davepacheco
left a comment
davepacheco
left a comment
There was a problem hiding this comment.
Thanks!
I think this is right but want to double-check with @hawkw because I remember there being some case(s) where the external message is the internal message.
davepacheco
added a commit
that referenced
this pull request
Dec 6, 2024
davepacheco
added a commit
that referenced
this pull request
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like a copy-paste that wasn't then edited afterwards. Noticed it while messing around with
nshalman@34c441b
This is just a bug report with a patch. Feel free to re-implement in a different commit elsewhere, etc.