Conversation
Refer to the inline code comment for all the details.
ahl
left a comment
ahl
left a comment
There was a problem hiding this comment.
Nice work chasing this down? Is there anything related to the initial bug beyond what you document in the code that's worth capturing in this PR?
| * Validate that the string is a valid Rust identifier. | ||
| */ | ||
| fn valid_identifier(var: &str) -> bool { | ||
| // TODO: Remove this "Once" callback when the following issue |
There was a problem hiding this comment.
FWIW @davepacheco has tried (and failed) to hold the line on /* */ comments in dropshot so... do what you will with that .
There was a problem hiding this comment.
Interesting, I always considered that comment style "valid, but non-idiomatic" - the Rust book only shows the "//" style (see: here) and there was even an (admittedly unsuccessful) attempt to remove block comments: rust-lang/rfcs#1371
(Plus I heard a rustlang maintainer also had the spicy take that they're not idiomatic)
Do you want me to switch before landing? I noticed we're pretty inconsistent across many of Oxide's repos (dunno if we should clarify which repos do / don't have this styling more explicitly).
There was a problem hiding this comment.
The rustdoc book also exclusively uses the non-block comment style ("//" or "///")
I don't believe so - it's a bit hairy, and might change if we made other calls to I'm kinda hoping that this gets resolved in upstream rust, fixed in proc_macro2, we can remove the hack, and we'll be done with it. |
2 participants
Refer to the inline code comment for all the details.