Skip to content

migrate to openapiv3 1.0.0-beta.3#161

Merged
ahl merged 6 commits intomainfrom
openapiv3-1.0
Nov 8, 2021
Merged

migrate to openapiv3 1.0.0-beta.3#161
ahl merged 6 commits intomainfrom
openapiv3-1.0

Conversation

@ahl
Copy link
Copy Markdown
Collaborator

@ahl ahl commented Oct 19, 2021

I've been trying to get openapiv3 ready for a "1.0". A corner case regarding array handling seemed like a decent reason to try out the new version. This includes some other tidying up.

@ahl ahl requested a review from davepacheco October 19, 2021 05:59
@davepacheco
Copy link
Copy Markdown
Collaborator

I don't totally understand all the checks but this seems fine. If we want to remove the deprecated function we should definitely update the changelog and make sure we bump the Dropshot version so that this is semver-incompatible.

@ahl
Copy link
Copy Markdown
Collaborator Author

ahl commented Oct 21, 2021

If we want to remove the deprecated function we should definitely update the changelog and make sure we bump the Dropshot version so that this is semver-incompatible.

I don't have a preference. We can leave it or I can bump the version -- do you have a preference?

@davepacheco
Copy link
Copy Markdown
Collaborator

Yeah, I definitely want to honor semver with Dropshot's version number. I'd like to have entries in the changelog for breaking changes that explain how to know if you're affected and what to do about it. This one would be pretty simple: if you're using this function, use that other function instead.

@ahl ahl changed the title migrate to openapiv3 1.0.0-beta.2 migrate to openapiv3 1.0.0-beta.3 Nov 7, 2021
@ahl
Copy link
Copy Markdown
Collaborator Author

ahl commented Nov 7, 2021

@davepacheco does this suffice?

@davepacheco
Copy link
Copy Markdown
Collaborator

Yes, that note's perfect. Thanks!

@ahl ahl merged commit f2f56a8 into main Nov 8, 2021
@ahl ahl deleted the openapiv3-1.0 branch November 8, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants