Allow use of usdt probes with stable rust#317
Merged
davepacheco merged 1 commit intooxidecomputer:mainfrom Apr 8, 2022
Merged
Conversation
bnaecker
reviewed
Apr 7, 2022
bnaecker
approved these changes
Apr 7, 2022
Collaborator
|
Nice! Is there any impact for the changelog? What does this mean for dropshot consumers? |
Contributor
|
Dropshot consumers should now be able to get USDT probes building on a stable compiler, as long as that's version >= 1.59, and they're not on macOS. The macOS implementation of |
Contributor
Author
|
Added an update to the changelog to mention this. |
The `usdt` crate can be built with stable toolchains as of Rust v1.59, except on MacOS, where the still-unstable `asm_sym` feature is needed. Dropshot should do proper compiler version detection so it too can be built with the stable toolchain when `usdt` is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
usdtcrate can be built with stable toolchains as of Rust v1.59,except on MacOS, where the still-unstable
asm_symfeature is needed.Dropshot should do proper compiler version detection so it too can be
built with the stable toolchain when
usdtis enabled.