Skip to content

Bump usdt dependency to support stable toolchains#522

Merged
davepacheco merged 2 commits intomainfrom
stable-usdt
Jan 11, 2023
Merged

Bump usdt dependency to support stable toolchains#522
davepacheco merged 2 commits intomainfrom
stable-usdt

Conversation

@bnaecker
Copy link
Copy Markdown
Contributor

No description provided.

@davepacheco
Copy link
Copy Markdown
Collaborator

The CI failure is #523. Looks like this needs to be sync'd with "main".

Copy link
Copy Markdown
Collaborator

@davepacheco davepacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the CHANGELOG?

I don't totally grok the dropshot/build.rs change. Maybe a comment there would be useful?

@davepacheco
Copy link
Copy Markdown
Collaborator

I buried the lede. I'm really excited about this big step towards stable!

@bnaecker bnaecker requested a review from davepacheco December 21, 2022 22:37
Copy link
Copy Markdown
Collaborator

@davepacheco davepacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good...but also seems easy to mess up. @ahl want to take a look too?

Copy link
Copy Markdown
Collaborator

@ahl ahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

Comment thread dropshot/build.rs
@davepacheco
Copy link
Copy Markdown
Collaborator

See also #561

@bnaecker
Copy link
Copy Markdown
Contributor Author

My fault for multiple PRs. I meant to merge these, but just forgot to do so. #561 does the build.rs updates for better detection of the features, and this PR updates the actual usdt dependency and adds changelog notes.

@davepacheco davepacheco merged commit 120e168 into main Jan 11, 2023
@davepacheco davepacheco deleted the stable-usdt branch January 11, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants