Add required-without-page_token information to pagination extension#660
Merged
Add required-without-page_token information to pagination extension#660
Conversation
davepacheco
approved these changes
May 1, 2023
Collaborator
davepacheco
left a comment
There was a problem hiding this comment.
Do I grok correctly that there's no impact on dropshot consumers here (unless they're using the openapi extension)?
Co-authored-by: David Pacheco <dap@oxidecomputer.com>
Collaborator
Author
Yes; that's accurate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
x-dropshot-paginationwas simply the valuetrue. Now it's an object with a fieldrequiredthat is an array of strings that tell us what query parameters are required to fetch the first page (i.e. whenpage_tokenis not specified).This also cleans up some stray doc nits.