Set a default probe speed - #721
Merged
Merged
Conversation
jamesmunns
approved these changes
Aug 6, 2026
|
Empirically, the changes here are fast enough to avoid full duty cycle fans on The runtime of
See - https://github.com/oxidecomputer/facade/issues/727#issuecomment-5209160547 |
adamlouis
approved these changes
Aug 6, 2026
Contributor
Author
|
Verified that 8mhz probe speed works on OxLink, old MCULink and STLink so it should be fine for most use cases. |
Newer probe-rs changed the `read_8` backend to actually use 8-bit reads instead of just relying on `read_32`. This introduces a noticable performance regression. Using a faster probe speed improves the performance to what we expect. With `read_32` the probe itself was not the bottleneck whereas repeated reads with `read_8` require a probe to go at a faster speed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer probe-rs changed the
read_8backend to actually use 8-bit reads instead of just relying onread_32. This introduces a noticable performance regression. Using a faster probe speed improves the performance to what we expect. Withread_32the probe itself was not the bottleneck whereas repeated reads withread_8require a probe to go at a faster speed.