Fixing flake related to tokio::fs::write cancellation - #10192
Merged
Conversation
smklein
changed the title
Member
|
Do we think there may be other tests that have similar issues around tempdir creation/removal? |
Collaborator
Author
ha you found my to-do list for the rest of the morning. Haven't looked yet, but I had this question too. I can look. |
Collaborator
Author
|
Filing #10198 to separate it from this fix |
sunshowers
approved these changes
Mar 31, 2026
sunshowers
left a comment
sunshowers
left a comment
Contributor
There was a problem hiding this comment.
I'd like to move temp dir management to within nextest at some point, which would avoid this class of issues. Something for the future :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flake in
test_instance_create_timeout_while_starting_propolisManually constructs a tokio runtime, and prevents a temporary directory from being dropped
while any tokio tasks - explicitly or implicitly created - might still be alive.
Fixes #10063