[nexus] skip deleted ereports when determining latest ENA#10752
Merged
Conversation
As @smklein pointed out in [this comment][1]. [1]: #10746 (comment)
smklein
approved these changes
Jul 6, 2026
Member
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @smklein pointed out in this comment, the
Datastore::lates_ena_for_restart_on_connquery does not filter out ereportsWHERE time_deleted IS NOT NULL, and it probably should be doing that. I didn't see the comment on #10746 until after I clicked the "merge" button on that branch due to github UI jankiness, so this PR fixes it. I also added a quick doc comment.