[omdb] remove full scans in webhook delivery list, refactoring#10758
Merged
Conversation
mergeconflict
approved these changes
Jul 7, 2026
Comment on lines
+686
to
+688
| rx_lookup.lookup_for(authz::Action::Read).await.with_context( | ||
| || format!("looking up alert receiver {receiver} failed"), | ||
| )?; |
Contributor
There was a problem hiding this comment.
I don't think this handles --include-deleted. As far as I can tell, the old lookup_webhook_rx didn't handle it either, and webhook_rx_delete hard-deletes the receiver's children anyway, but maybe there's some inconsistency here that wasn't intended.
Member
Author
There was a problem hiding this comment.
yeah, because these are hard-deleted, there isn't really a nice way to implement include_deleted for this command. i'm not too worried about that.
hawkw
force-pushed
the
eliza/fix-omdb-webhooks-full-scan
branch
from
July 7, 2026 21:06
ab41491 to
99b2af1
Compare
Member
Author
|
seems |
hawkw
enabled auto-merge (squash)
July 7, 2026 21:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #10753.
It turns out the query in
omdb db alert webhook delivery listis also very full-table-scan-y, so this branch basically gives it the same treatment as I gavealert listin #10753. I also made similar clap changes here, so we get nice help text for possible values.