[28/n] [wicketd] extract the baseboard/SP-state match into a helper#10922
Merged
sunshowers merged 1 commit intoJul 24, 2026
Conversation
Created using spr 1.3.6-beta.1
andrewjstone
approved these changes
Jul 24, 2026
Contributor
There was a problem hiding this comment.
This looks fine. But, It's almost certainly going to become useless, or require changes with #10518.
#10518 reduces the usage of the Baseboard type quite a bit. I actually think we should either get rid of it entirely or change to a struct rather than an enum with board types. Even now we use the Gimlet enum for things like switches and cosmos and it is nothing but a hassle.
Contributor
Author
Yeah to be clear my goal was just to move this into a common location -- which is why I added a bunch of comments for the future. |
sunshowers
deleted the
sunshowers/spr/28n-wicketd-extract-the-baseboardsp-state-match-into-a-helper
branch
July 24, 2026 23:31
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This determination is used in a couple of spots, and we're going to add a third one soon.
This is a pure refactor with no functional changes (other than swapping the model/part number and serial number order for consistency with
BaseboardId), though it raises a few questions that need to be answered in the future.