Report reservoir size on error if possible - #11149
Merged
papertigers merged 2 commits intoAug 27, 2026
Merged
Conversation
leftwo
approved these changes
Aug 27, 2026
leftwo
left a comment
leftwo
left a comment
Contributor
There was a problem hiding this comment.
This is not our final answer, but it does put us in a better place than zero.
papertigers
marked this pull request as ready for review
August 27, 2026 16:51
papertigers
deleted the
spr/papertigers/report-reservoir-size-on-error-if-possible
branch
August 27, 2026 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we fail to set the reservoir size, say due to an ENOMEM, we record a zero for reservoir_size in
crdb. It's much better if we report how much memory we were actually able stuff in the reservoir so
that instances could still land on the sled.