Skip to content

Conversation

@jgallagher
Copy link
Contributor

This is very untested: it successfully creates an omicron-gateway.tar.gz zone package that contains the expected files:

$ tar tf out/omicron-gateway.tar.gz
oxide.json
root/
root/var
root/var/svc
root/var/svc/manifest
root/var/svc/manifest/site
root/var/svc/manifest/site/mgs
root/var/svc/manifest/site/mgs/config.toml
root/var/svc/manifest/site/mgs/manifest.xml
root/
root/opt
root/opt/oxide
root/opt/oxide/mgs
root/opt/oxide/mgs/bin
root/opt/oxide/mgs/bin/mgs

but that's the full extent of the testing done. Nothing in this PR adds the ability to install this zone, and at best if we could launch it, we'd get error logs as it failed to find SPs.

Minor changes that attempt to bring MGS more in line with other control plane services:

  • We now take our ID and listening address as command line args
  • Renamed the binary to mgs

@jgallagher jgallagher requested a review from smklein October 6, 2022 15:55
Copy link
Collaborator

@smklein smklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as a first step.

When #1819 is merged, we should be able to create a new "composite" scrimlet package, using MGS as an "intermediate" package.

@jgallagher jgallagher merged commit 106cd83 into main Oct 14, 2022
@jgallagher jgallagher deleted the mgs-zone branch October 14, 2022 14:14
leftwo pushed a commit that referenced this pull request Oct 24, 2025
Crucible changes:
Enforce write order of blocks and dirty bit (#1798)
Remove unnecessary `unused_async` (#1795)
Add `crucible-downstairs validate` subcommand (#1792)
Remove incorrect `expect(unused)` annotation (#1789)
Handle errors in get-up-state.sh (#1787)
Handle final live-repair flush being skipped on all downstairs (#1783)
Offline downstairs go to faulted when LR starts (#1777)
update drift to pick up fix for OpenAPI type graph cycles (#1785)
make Crucible APIs versioned (#1782)

Propolis had no changes.
@leftwo leftwo mentioned this pull request Oct 24, 2025
leftwo added a commit that referenced this pull request Oct 27, 2025
Just Crucible changes, propolis did not change (other than Crucible)

Crucible changes:
Enforce write order of blocks and dirty bit (#1798)
Remove unnecessary `unused_async` (#1795)
Add `crucible-downstairs validate` subcommand (#1792)
Remove incorrect `expect(unused)` annotation (#1789)
Handle errors in get-up-state.sh (#1787)
Handle final live-repair flush being skipped on all downstairs (#1783)
Offline downstairs go to faulted when LR starts (#1777)
update drift to pick up fix for OpenAPI type graph cycles (#1785)
make Crucible APIs versioned (#1782)

---------

Co-authored-by: Alan Hanson <alan@oxide.computer>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants