FlowEntry child list should have a bounded length - #1043
Merged
Conversation
FelixMcFelix
force-pushed
the
bound-flow-children
branch
from
September 2, 2026 11:29
c6a3cee to
836e361
Compare
rcgoodfellow
self-requested a review
September 2, 2026 21:23
rcgoodfellow
approved these changes
Sep 2, 2026
rcgoodfellow
left a comment
rcgoodfellow
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just one non blocking note on observability.
rcgoodfellow
reviewed
Sep 2, 2026
rcgoodfellow
approved these changes
Sep 3, 2026
This was not the cause of our performance woes relating to flow expiry, but I think that it's a strong belt-and-braces property worth enforcing all of the time anyhow.
FelixMcFelix
force-pushed
the
bound-flow-children
branch
from
September 3, 2026 21:23
3133a16 to
7fa1ae8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LFT
FlowEntryelements track a list of all their children. These are our UFT and TCP flow entries -- if we evict an LFT entry, then the child entries can no longer be used. We also use these lists to determine whether an LFT entry can be evicted using the active TCP flow state information, if present.We know that this set should be bounded, so this PR makes this into a hard requirement to cap the amount of time we can spend computing any one flow's eviction score. This was not the cause of our performance woes relating to flow expiry, but I think that it's a strong belt-and-braces property worth enforcing all of the time.