Revert dropshot bumps, run all tests in ci#1128
Closed
jmpesp wants to merge 4 commits intooxidecomputer:masterfrom
Closed
Revert dropshot bumps, run all tests in ci#1128jmpesp wants to merge 4 commits intooxidecomputer:masterfrom
jmpesp wants to merge 4 commits intooxidecomputer:masterfrom
Conversation
Currently `cargo xtask openapi check` is failing for master. the `test_apis_up_to_date` catches this but was not running in CI. my theory is that picking up oxidecomputer/dropshot#1554 caused openapi document generation to change, conflicting with the blessed version. Reverting fixes things, so: downgrade dropshot to 0.16.7 and dropshot-api-manager related crates to 0.6.0, and add a CI job that runs `cargo test --locked`.
Contributor
Author
|
Closing in favour of #1129 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
cargo xtask openapi checkis failing for master. thetest_apis_up_to_datecatches this but was not running in CI. my theory is that picking up oxidecomputer/dropshot#1554 caused openapi document generation to change, conflicting with the blessed version.Reverting fixes things, so: downgrade dropshot to 0.16.7 and dropshot-api-manager related crates to 0.6.0, and add a CI job that runs
cargo test --locked.